Bug 148718 - GetById inline caches should use the One True Stub approach rather than a linked list of stubs
Summary: GetById inline caches should use the One True Stub approach rather than a lin...
Status: RESOLVED DUPLICATE of bug 148717
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 148725 148743 148766
Blocks: 148717
  Show dependency treegraph
 
Reported: 2015-09-02 10:39 PDT by Filip Pizlo
Modified: 2015-09-04 15:03 PDT (History)
0 users

See Also:


Attachments
a small start (11.42 KB, patch)
2015-09-02 22:36 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
more (17.11 KB, patch)
2015-09-03 11:44 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
getting interesting (43.57 KB, patch)
2015-09-03 19:13 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-09-02 10:39:55 PDT
Instead of doing https://bugs.webkit.org/show_bug.cgi?id=148717 all at once, I will tackle the GetById caches first.
Comment 1 Filip Pizlo 2015-09-02 22:36:55 PDT
Created attachment 260488 [details]
a small start
Comment 2 Filip Pizlo 2015-09-03 11:44:40 PDT
Created attachment 260502 [details]
more

Oh man, this is painful.
Comment 3 Filip Pizlo 2015-09-03 17:20:30 PDT
It seems like I should probably do this at the same time as https://bugs.webkit.org/show_bug.cgi?id=148717, because my approach involves moving logic out of StructureStubInfo/Repatch and into PolymorphicGetByIdList.  But a lot of that logic is shared by the put_by_id paths, so probably PolymorphicPutByIdList should be folded into PolymorphicGetByIdList.
Comment 4 Filip Pizlo 2015-09-03 19:13:03 PDT
Created attachment 260550 [details]
getting interesting
Comment 5 Filip Pizlo 2015-09-04 15:03:51 PDT
I think that it's better to handle all of the inline caches in one go, rather than trying to just fix get_by_id.

*** This bug has been marked as a duplicate of bug 148717 ***