Bug 148725 - Replace all the various forms of branchStructure() with a single method in AssemblyHelpers
Summary: Replace all the various forms of branchStructure() with a single method in As...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 148718
  Show dependency tree / graph
 
Reported: 2015-09-02 15:11 PDT by Filip Pizlo
Modified: 2015-09-02 20:17 PDT (History)
0 users

See Also:

Attachments
the patch (12.47 KB, patch)
2015-09-02 15:19 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-09-02 15:11:38 PDT 
Currently there are the following branchStructure() implementations:

JSC::JIT::branchStructure()
JSC::branchStructure()
JSC::DFG::JITCompiler::branchStructure()

They all do the same thing.  There should only be one.
Comment 1 Filip Pizlo 2015-09-02 15:19:33 PDT 
Created attachment 260446 [details]
the patch
Comment 2 Saam Barati 2015-09-02 15:24:30 PDT 
Comment on attachment 260446 [details]
the patch

r=me
I like duplicate code removal.
Comment 3 Filip Pizlo 2015-09-02 20:17:32 PDT 
Landed in http://trac.webkit.org/changeset/189272