Bug 148766 - WatchpointsOnStructureStubInfo doesn't need to be reference counted
Summary: WatchpointsOnStructureStubInfo doesn't need to be reference counted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 148718
  Show dependency treegraph
 
Reported: 2015-09-03 18:13 PDT by Filip Pizlo
Modified: 2015-09-03 18:21 PDT (History)
11 users (show)

See Also:


Attachments
the patch (4.16 KB, patch)
2015-09-03 18:14 PDT, Filip Pizlo
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-09-03 18:13:28 PDT
It doesn't need to be reference counted because the only RefPtr to it is in StructureStubInfo.  Therefore, it can be a unique_ptr.
Comment 1 Filip Pizlo 2015-09-03 18:14:25 PDT
Created attachment 260546 [details]
the patch
Comment 2 Saam Barati 2015-09-03 18:16:35 PDT
Comment on attachment 260546 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-09-03 18:21:15 PDT
Landed in http://trac.webkit.org/changeset/189328