Bug 146852 – Cleanup: WebCore::Pair class should use RefPtr&& instead of PassRefPtr

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

We should use RefPtr&& instead of PassRefPtr in the class definition for WebCore::Pair.

[Daniel Bates]

Created attachment 256605 [details]
Patch

[WebKit Commit Bot]

Attachment 256605 [details] did not pass style-queue:


ERROR: Source/WebCore/css/Pair.h:62:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/Pair.h:63:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Comment on attachment 256605 [details]
Patch

Clearing flags on attachment: 256605

Committed r186685: <http://trac.webkit.org/changeset/186685>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 256605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256605&action=review

> Source/WebCore/css/Pair.h:62
> +    Pair() : m_first(nullptr), m_second(nullptr) { }

This nullptr stuff is not needed; RefPtr gets null automatically without explicit initialization. Should just be:

    Pair() { }

Assuming we can’t omit this entirely.

[Radar WebKit Bug Importer]

<rdar://problem/21772881>

[Daniel Bates]

(In reply to comment #5)
> Comment on attachment 256605 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256605&action=review
> 
> > Source/WebCore/css/Pair.h:62
> > +    Pair() : m_first(nullptr), m_second(nullptr) { }
> 
> This nullptr stuff is not needed; RefPtr gets null automatically without
> explicit initialization. Should just be:
> 
>     Pair() { }
> 
> Assuming we can’t omit this entirely.

Filed bug #146856 to remove the default constructor.