Bug 146856 - Cleanup: Remove default constructor for WebCore::Pair()
Summary: Cleanup: Remove default constructor for WebCore::Pair()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-10 14:00 PDT by Daniel Bates
Modified: 2015-07-10 20:46 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.78 KB, patch)
2015-07-10 14:05 PDT, Daniel Bates 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-07-10 14:00:58 PDT 
Following up on Darin Adler's remark in bug 146852, comment 5, we should remove the default constructor for WebCore::Pair as we are not making use of it. Similarly, we can remove the setters Pair::setFirst() and Pair::setSecond() since this are unused and it seems weird to expose such setter when we do not have a default constructor.
Comment 1 Radar WebKit Bug Importer 2015-07-10 14:04:51 PDT 
<rdar://problem/21773212>
Comment 2 Daniel Bates 2015-07-10 14:05:32 PDT 
Created attachment 256613 [details]
Patch
Comment 3 Daniel Bates 2015-07-10 20:46:25 PDT 
Committed r186704: <http://trac.webkit.org/changeset/186704>