WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
146856
Cleanup: Remove default constructor for WebCore::Pair()
https://bugs.webkit.org/show_bug.cgi?id=146856
Summary
Cleanup: Remove default constructor for WebCore::Pair()
Daniel Bates
Reported
2015-07-10 14:00:58 PDT
Following up on Darin Adler's remark in
bug 146852, comment 5
, we should remove the default constructor for WebCore::Pair as we are not making use of it. Similarly, we can remove the setters Pair::setFirst() and Pair::setSecond() since this are unused and it seems weird to expose such setter when we do not have a default constructor.
Attachments
Patch
(2.78 KB, patch)
2015-07-10 14:05 PDT
,
Daniel Bates
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-07-10 14:04:51 PDT
<
rdar://problem/21773212
>
Daniel Bates
Comment 2
2015-07-10 14:05:32 PDT
Created
attachment 256613
[details]
Patch
Daniel Bates
Comment 3
2015-07-10 20:46:25 PDT
Committed
r186704
: <
http://trac.webkit.org/changeset/186704
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug