Bug 143191 – Serialized declaration for background-size/-webkit-mask-size should preserve identical values instead of coalescing them

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Erik Aigner]

When setting `background-size:100% 100%` on a BODY element, WebKit2 (WKWebView) rewrites it to `background-size:100%` which is equivalent to `100% auto`. This is a clear violation of the spec.

See http://stackoverflow.com/questions/29327537/css-background-size-ignores-2nd-value?noredirect=1#comment46845162_29327537 for discussion

[Daniel Bates]

Created attachment 256552 [details]
Patch and layout tests

[WebKit Commit Bot]

Attachment 256552 [details] did not pass style-queue:


ERROR: Source/WebCore/css/Pair.h:75:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/Pair.h:76:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Created attachment 256553 [details]
Patch and layout tests

Update Apple copyright line in file Source/WebCore/css/Pair.h

[WebKit Commit Bot]

Attachment 256553 [details] did not pass style-queue:


ERROR: Source/WebCore/css/Pair.h:75:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/Pair.h:76:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Radar WebKit Bug Importer]

<rdar://problem/21759393>

[Radar WebKit Bug Importer]

<rdar://problem/21759395>

[Daniel Bates]

(In reply to comment #6)
> <rdar://problem/21759395>

Disregard this comment.

[Daniel Bates]

I

[Darin Adler]

Comment on attachment 256553 [details]
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=256553&action=review

> Source/WebCore/css/Pair.h:50
> +    static Ref<Pair> create(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second, IdenticalValueEncoding encoding)

Arguments should be RefPtr&&, not PassRefPtr.

> Source/WebCore/css/Pair.h:76
> +    Pair(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second) : m_first(first), m_second(second) { }
> +    Pair(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second, IdenticalValueEncoding encoding) : m_first(first), m_second(second), m_encoding(encoding) { }

Arguments should be RefPtr&&, not PassRefPtr.

[Daniel Bates]

(In reply to comment #9)
> > Source/WebCore/css/Pair.h:50
> > +    static Ref<Pair> create(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second, IdenticalValueEncoding encoding)
> 
> Arguments should be RefPtr&&, not PassRefPtr.
> 

Will fix before landing.

> > Source/WebCore/css/Pair.h:76
> > +    Pair(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second) : m_first(first), m_second(second) { }
> > +    Pair(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second, IdenticalValueEncoding encoding) : m_first(first), m_second(second), m_encoding(encoding) { }
> 
> Arguments should be RefPtr&&, not PassRefPtr.

Will fix before landing.

[Daniel Bates]

Committed r186687: <http://trac.webkit.org/changeset/186687>