Bug 145396 – REGRESSION(r184872): Bindings tests broken on the bots. (Requested by dethbakin on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Commit Bot]

http://trac.webkit.org/changeset/184872 broke the build:
Bindings tests broken on the bots. (Requested by dethbakin on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 253753 [details]
ROLLOUT of r184872

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Beth Dakin]

Here is the output of the failing bindings tests for future reference: 

(view as text)
python ./Tools/Scripts/run-bindings-tests
 in dir /Volumes/Data/slave/yosemite-debug-tests-wk2/build (timeout 1200 secs)
 watching logfiles {}
 argv: ['python', './Tools/Scripts/run-bindings-tests']
 environment:
  Apple_PubSub_Socket_Render=/private/tmp/com.apple.launchd.NzXM5OiteI/Render
  HOME=/Users/buildbot
  LOGNAME=buildbot
  OLDPWD=/Users/buildbot
  PATH=/usr/bin:/bin:/usr/sbin:/sbin
  PWD=/Volumes/Data/slave/yosemite-debug-tests-wk2/build
  SHELL=/bin/bash
  SHLVL=1
  SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.vyEiSPi6Q5/Listeners
  TMPDIR=/var/folders/k1/1ttd8pg161b8bnbstk_tjmz40000gn/T/
  USER=buildbot
  VERSIONER_PYTHON_PREFER_32_BIT=no
  VERSIONER_PYTHON_VERSION=2.7
  XPC_FLAGS=0x0
  XPC_SERVICE_NAME=0
  _=/usr/bin/twistd
  __CF_USER_TEXT_ENCODING=0x1F5:0x0:0x0
 using PTY: False
PASS: (JS) JSTestCallback.cpp
PASS: (JS) JSTestCallback.h
PASS: (JS) JSTestCustomConstructorWithNoInterfaceObject.cpp
FAIL: (JS) JSTestCustomConstructorWithNoInterfaceObject.h
--- WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h	2015-05-26 14:52:03.000000000 -0700
+++ /var/folders/k1/1ttd8pg161b8bnbstk_tjmz40000gn/T/tmp0pXyrS/JSTestCustomConstructorWithNoInterfaceObject.h	2015-05-26 15:30:10.000000000 -0700
@@ -27,7 +27,7 @@
 
 namespace WebCore {
 
-class WEBCORE_EXPORT JSTestCustomConstructorWithNoInterfaceObject : public JSDOMWrapper {
+class JSTestCustomConstructorWithNoInterfaceObject : public JSDOMWrapper {
 public:
     typedef JSDOMWrapper Base;
     static JSTestCustomConstructorWithNoInterfaceObject* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, Ref<TestCustomConstructorWithNoInterfaceObject>&& impl)
@@ -78,7 +78,7 @@
     return &owner.get();
 }
 
-WEBCORE_EXPORT JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, TestCustomConstructorWithNoInterfaceObject*);
+JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, TestCustomConstructorWithNoInterfaceObject*);
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, TestCustomConstructorWithNoInterfaceObject& impl) { return toJS(exec, globalObject, &impl); }
 
 // Custom constructor

PASS: (JS) JSTestCustomNamedGetter.cpp
PASS: (JS) JSTestCustomNamedGetter.h
PASS: (JS) JSTestActiveDOMObject.cpp
PASS: (JS) JSTestActiveDOMObject.h
PASS: (JS) JSTestEventConstructor.cpp
PASS: (JS) JSTestEventConstructor.h
PASS: (JS) JSTestEventTarget.cpp
PASS: (JS) JSTestEventTarget.h
PASS: (JS) JSattribute.cpp
PASS: (JS) JSattribute.h
PASS: (JS) JSTestException.cpp
PASS: (JS) JSTestException.h
PASS: (JS) JSTestGenerateIsReachable.cpp
PASS: (JS) JSTestGenerateIsReachable.h
PASS: (JS) JSTestImplements.cpp
PASS: (JS) JSTestImplements.h
PASS: (JS) JSreadonly.cpp
PASS: (JS) JSreadonly.h
PASS: (JS) JSTestInterface.cpp
PASS: (JS) JSTestInterface.h
PASS: (JS) JSTestMediaQueryListListener.cpp
PASS: (JS) JSTestMediaQueryListListener.h
PASS: (JS) JSTestNamedConstructor.cpp
PASS: (JS) JSTestNamedConstructor.h
PASS: (JS) JSTestNode.cpp
PASS: (JS) JSTestNode.h
PASS: (JS) JSTestNondeterministic.cpp
PASS: (JS) JSTestNondeterministic.h
PASS: (JS) JSTestObj.cpp
PASS: (JS) JSTestObj.h
PASS: (JS) JSTestOverloadedConstructors.cpp
PASS: (JS) JSTestOverloadedConstructors.h
PASS: (JS) JSTestSerializedScriptValueInterface.cpp
PASS: (JS) JSTestSerializedScriptValueInterface.h
PASS: (JS) JSTestSupplemental.cpp
PASS: (JS) JSTestSupplemental.h
PASS: (JS) JSTestTypedefs.cpp
PASS: (JS) JSTestTypedefs.h
PASS: (ObjC) DOMTestCallback.h
PASS: (ObjC) DOMTestCallback.mm
PASS: (ObjC) DOMTestCallbackInternal.h
PASS: (ObjC) DOMTestCustomConstructorWithNoInterfaceObject.h
FAIL: (ObjC) DOMTestCustomConstructorWithNoInterfaceObject.mm
--- WebCore/bindings/scripts/test/ObjC/DOMTestCustomConstructorWithNoInterfaceObject.mm	2015-05-26 14:52:03.000000000 -0700
+++ /var/folders/k1/1ttd8pg161b8bnbstk_tjmz40000gn/T/tmpTF0VcJ/DOMTestCustomConstructorWithNoInterfaceObject.mm	2015-05-26 15:30:13.000000000 -0700
@@ -69,7 +69,7 @@
 
 DOMTestCustomConstructorWithNoInterfaceObject *kit(WebCore::TestCustomConstructorWithNoInterfaceObject* value)
 {
-    { DOM_ASSERT_MAIN_THREAD(); WebCoreThreadViolationCheckRoundOne(); };
+    WebCoreThreadViolationCheckRoundOne();
     if (!value)
         return nil;
     if (DOMTestCustomConstructorWithNoInterfaceObject *wrapper = getDOMWrapper(value))

PASS: (ObjC) DOMTestCustomConstructorWithNoInterfaceObjectInternal.h
PASS: (ObjC) DOMTestCustomNamedGetter.h
PASS: (ObjC) DOMTestCustomNamedGetter.mm
PASS: (ObjC) DOMTestCustomNamedGetterInternal.h
PASS: (ObjC) DOMTestActiveDOMObject.h
PASS: (ObjC) DOMTestActiveDOMObject.mm
PASS: (ObjC) DOMTestActiveDOMObjectInternal.h
PASS: (ObjC) DOMTestEventConstructor.h
PASS: (ObjC) DOMTestEventConstructor.mm
PASS: (ObjC) DOMTestEventConstructorInternal.h
PASS: (ObjC) DOMTestEventTarget.h
PASS: (ObjC) DOMTestEventTarget.mm
PASS: (ObjC) DOMTestEventTargetInternal.h
PASS: (ObjC) DOMattribute.h
PASS: (ObjC) DOMattribute.mm
PASS: (ObjC) DOMattributeInternal.h
PASS: (ObjC) DOMTestException.h
PASS: (ObjC) DOMTestException.mm
PASS: (ObjC) DOMTestExceptionInternal.h
PASS: (ObjC) DOMTestGenerateIsReachable.h
PASS: (ObjC) DOMTestGenerateIsReachable.mm
PASS: (ObjC) DOMTestGenerateIsReachableInternal.h
PASS: (ObjC) DOMTestImplements.cpp
PASS: (ObjC) DOMTestImplements.h
PASS: (ObjC) DOMreadonly.h
PASS: (ObjC) DOMreadonly.mm
PASS: (ObjC) DOMreadonlyInternal.h
PASS: (ObjC) DOMTestInterface.h
PASS: (ObjC) DOMTestInterface.mm
PASS: (ObjC) DOMTestInterfaceInternal.h
PASS: (ObjC) DOMTestMediaQueryListListener.h
PASS: (ObjC) DOMTestMediaQueryListListener.mm
PASS: (ObjC) DOMTestMediaQueryListListenerInternal.h
PASS: (ObjC) DOMTestNamedConstructor.h
PASS: (ObjC) DOMTestNamedConstructor.mm
PASS: (ObjC) DOMTestNamedConstructorInternal.h
PASS: (ObjC) DOMTestNode.h
PASS: (ObjC) DOMTestNode.mm
PASS: (ObjC) DOMTestNodeInternal.h
PASS: (ObjC) DOMTestNondeterministic.h
PASS: (ObjC) DOMTestNondeterministic.mm
PASS: (ObjC) DOMTestNondeterministicInternal.h
PASS: (ObjC) DOMTestObj.h
PASS: (ObjC) DOMTestObj.mm
PASS: (ObjC) DOMTestObjInternal.h
PASS: (ObjC) DOMTestOverloadedConstructors.h
PASS: (ObjC) DOMTestOverloadedConstructors.mm
PASS: (ObjC) DOMTestOverloadedConstructorsInternal.h
PASS: (ObjC) DOMTestSerializedScriptValueInterface.h
PASS: (ObjC) DOMTestSerializedScriptValueInterface.mm
PASS: (ObjC) DOMTestSerializedScriptValueInterfaceInternal.h
PASS: (ObjC) DOMTestSupplemental.cpp
PASS: (ObjC) DOMTestSupplemental.h
PASS: (ObjC) DOMTestTypedefs.h
PASS: (ObjC) DOMTestTypedefs.mm
PASS: (ObjC) DOMTestTypedefsInternal.h
PASS: (GObject) WebKitDOMTestCallback.cpp
PASS: (GObject) WebKitDOMTestCallback.h
PASS: (GObject) WebKitDOMTestCallbackPrivate.h
PASS: (GObject) WebKitDOMTestCustomConstructorWithNoInterfaceObject.cpp
PASS: (GObject) WebKitDOMTestCustomConstructorWithNoInterfaceObject.h
PASS: (GObject) WebKitDOMTestCustomConstructorWithNoInterfaceObjectPrivate.h
PASS: (GObject) WebKitDOMTestCustomNamedGetter.cpp
PASS: (GObject) WebKitDOMTestCustomNamedGetter.h
PASS: (GObject) WebKitDOMTestCustomNamedGetterPrivate.h
PASS: (GObject) WebKitDOMTestActiveDOMObject.cpp
PASS: (GObject) WebKitDOMTestActiveDOMObject.h
PASS: (GObject) WebKitDOMTestActiveDOMObjectPrivate.h
PASS: (GObject) WebKitDOMTestEventConstructor.cpp
PASS: (GObject) WebKitDOMTestEventConstructor.h
PASS: (GObject) WebKitDOMTestEventConstructorPrivate.h
PASS: (GObject) WebKitDOMTestEventTarget.cpp
PASS: (GObject) WebKitDOMTestEventTarget.h
PASS: (GObject) WebKitDOMTestEventTargetPrivate.h
PASS: (GObject) WebKitDOMattribute.cpp
PASS: (GObject) WebKitDOMattribute.h
PASS: (GObject) WebKitDOMattributePrivate.h
PASS: (GObject) WebKitDOMTestException.cpp
PASS: (GObject) WebKitDOMTestException.h
PASS: (GObject) WebKitDOMTestExceptionPrivate.h
PASS: (GObject) WebKitDOMTestGenerateIsReachable.cpp
PASS: (GObject) WebKitDOMTestGenerateIsReachable.h
PASS: (GObject) WebKitDOMTestGenerateIsReachablePrivate.h
PASS: (GObject) WebKitDOMTestImplements.cpp
PASS: (GObject) WebKitDOMTestImplements.h
PASS: (GObject) WebKitDOMreadonly.cpp
PASS: (GObject) WebKitDOMreadonly.h
PASS: (GObject) WebKitDOMreadonlyPrivate.h
PASS: (GObject) WebKitDOMTestInterface.cpp
PASS: (GObject) WebKitDOMTestInterface.h
PASS: (GObject) WebKitDOMTestInterfacePrivate.h
PASS: (GObject) WebKitDOMTestMediaQueryListListener.cpp
PASS: (GObject) WebKitDOMTestMediaQueryListListener.h
PASS: (GObject) WebKitDOMTestMediaQueryListListenerPrivate.h
PASS: (GObject) WebKitDOMTestNamedConstructor.cpp
PASS: (GObject) WebKitDOMTestNamedConstructor.h
PASS: (GObject) WebKitDOMTestNamedConstructorPrivate.h
PASS: (GObject) WebKitDOMTestNode.cpp
PASS: (GObject) WebKitDOMTestNode.h
PASS: (GObject) WebKitDOMTestNodePrivate.h
PASS: (GObject) WebKitDOMTestNondeterministic.cpp
PASS: (GObject) WebKitDOMTestNondeterministic.h
PASS: (GObject) WebKitDOMTestNondeterministicPrivate.h
PASS: (GObject) WebKitDOMTestObj.cpp
PASS: (GObject) WebKitDOMTestObj.h
PASS: (GObject) WebKitDOMTestObjPrivate.h
PASS: (GObject) WebKitDOMTestOverloadedConstructors.cpp
PASS: (GObject) WebKitDOMTestOverloadedConstructors.h
PASS: (GObject) WebKitDOMTestOverloadedConstructorsPrivate.h
PASS: (GObject) WebKitDOMTestSerializedScriptValueInterface.cpp
PASS: (GObject) WebKitDOMTestSerializedScriptValueInterface.h
PASS: (GObject) WebKitDOMTestSerializedScriptValueInterfacePrivate.h
PASS: (GObject) WebKitDOMTestSupplemental.cpp
PASS: (GObject) WebKitDOMTestSupplemental.h
PASS: (GObject) WebKitDOMTestTypedefs.cpp
PASS: (GObject) WebKitDOMTestTypedefs.h
PASS: (GObject) WebKitDOMTestTypedefsPrivate.h

Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
program finished with exit code 255
elapsedTime=8.838067

[WebKit Commit Bot]

Comment on attachment 253753 [details]
ROLLOUT of r184872

Clearing flags on attachment: 253753

Committed r184886: <http://trac.webkit.org/changeset/184886>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

Thanks bdakin for taking the time to roll out the patch for me.

The code generator was changed between the time I prepared the patch and the time I landed it (https://bugs.webkit.org/show_bug.cgi?id=145372 and https://bugs.webkit.org/show_bug.cgi?id=144932).

The new binding tests I added need to be rebased to cope with these changes.

Any idea why the commit queue did not catch these errors upfront?

[Beth Dakin]

(In reply to comment #5)
> Thanks bdakin for taking the time to roll out the patch for me.
> 
> The code generator was changed between the time I prepared the patch and the
> time I landed it (https://bugs.webkit.org/show_bug.cgi?id=145372 and
> https://bugs.webkit.org/show_bug.cgi?id=144932).
> 
> The new binding tests I added need to be rebased to cope with these changes.
> 
> Any idea why the commit queue did not catch these errors upfront?

Ah, makes sense!

My understanding is that the commit queue runs layout tests but not bindings tests?

[Darin Adler]

For bindings test failures, it’s usually OK to just regenerate results rather than doing a path rollout. Of course, there’s always a chance that the failure represents a real bug, but I don’t think it’s super-risky to regenerate results and then consider that question at leisure. Nothing like the risk of, say, skipping a failing regression test.