RESOLVED FIXED145372
ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD are unnecessary no-ops 
https://bugs.webkit.org/show_bug.cgi?id=145372
Summary ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD are unnecessary no-ops
mitz
Reported 2015-05-25 11:50:26 PDT
Some of the Legacy WebKit API entry points use ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD, but these macros have been no-ops since soon after their introduction over 8 years ago (<http://trac.webkit.org/r19280>, <http://trac.webkit.org/r19535>). All instances of DOM_ASSERT_MAIN_THREAD are followed by WebCoreThreadViolationCheckRoundOne(), which is a runtime exception by default. These macros (and the definition of DISABLE_THREAD_CHECK) could just be removed.
Attachments
Remove ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD and their uses (35.73 KB, patch)
2015-05-25 13:17 PDT, mitz 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2015-05-25 13:17:30 PDT
Created attachment 253691 [details] Remove ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD and their uses
mitz
Comment 2 2015-05-25 19:27:01 PDT
Fixed in <http://trac.webkit.org/r184853>.
Csaba Osztrogonác
Comment 3 2015-05-25 22:16:24 PDT
(In reply to comment #2) > Fixed in <http://trac.webkit.org/r184853>. It broke the bindings tests, please fix.
mitz
Comment 4 2015-05-25 22:20:47 PDT
(In reply to comment #3) > (In reply to comment #2) > > Fixed in <http://trac.webkit.org/r184853>. > > It broke the bindings tests, please fix. A bindings test. Thank you. Fixed in <http://trac.webkit.org/r184854>.
Note You need to log in before you can comment on or make changes to this bug.