Bug 145372 - ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD are unnecessary no-ops
Summary: ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD are unnecessary no-ops
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-25 11:50 PDT by mitz
Modified: 2015-05-25 22:20 PDT (History)
4 users (show)

See Also:

Attachments
Remove ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD and their uses (35.73 KB, patch)
2015-05-25 13:17 PDT, mitz 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2015-05-25 11:50:26 PDT 
Some of the Legacy WebKit API entry points use ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD, but these macros have been no-ops since soon after their introduction over 8 years ago (<http://trac.webkit.org/r19280>, <http://trac.webkit.org/r19535>). All instances of DOM_ASSERT_MAIN_THREAD are followed by WebCoreThreadViolationCheckRoundOne(), which is a runtime exception by default.

These macros (and the definition of DISABLE_THREAD_CHECK) could just be removed.
Comment 1 mitz 2015-05-25 13:17:30 PDT 
Created attachment 253691 [details]
Remove ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD and their uses
Comment 2 mitz 2015-05-25 19:27:01 PDT 
Fixed in <http://trac.webkit.org/r184853>.
Comment 3 Csaba Osztrogonác 2015-05-25 22:16:24 PDT 
(In reply to comment #2)
> Fixed in <http://trac.webkit.org/r184853>.

It broke the bindings tests, please fix.
Comment 4 mitz 2015-05-25 22:20:47 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Fixed in <http://trac.webkit.org/r184853>.
> 
> It broke the bindings tests, please fix.

A bindings test. Thank you.

Fixed in <http://trac.webkit.org/r184854>.