Bug 144932 – Don't export all JS bindings classes

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Alex Christensen]

Most of the JavaScript bindings don't need WEBCORE_EXPORT.  Let's manage a small list of those that do.

[Alex Christensen]

Created attachment 252992 [details]
Patch

[WebKit Commit Bot]

Attachment 252992 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h:93:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h:30:  Extra space between class and JSTestEventTarget  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h:93:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.h:83:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.h:30:  Extra space between class and JSTestNamedConstructor  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.h:83:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.h:82:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.h:30:  Extra space between class and JSTestMediaQueryListListener  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.h:82:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.h:98:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.h:30:  Extra space between class and JSTestObj  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.h:98:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h:84:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h:32:  Extra space between class and JSTestEventConstructor  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h:84:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h:85:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h:30:  Extra space between class and JSTestActiveDOMObject  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h:85:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.h:85:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.h:30:  Extra space between class and JSTestTypedefs  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.h:85:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.h:82:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.h:30:  Extra space between class and JSTestGenerateIsReachable  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.h:82:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestException.h:86:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestException.h:31:  Extra space between class and JSTestException  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestException.h:86:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.h:82:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.h:30:  Extra space between class and JSTestNondeterministic  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.h:82:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.h:82:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.h:30:  Extra space between class and JSTestOverloadedConstructors  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.h:82:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSreadonly.h:82:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSreadonly.h:30:  Extra space between class and JSreadonly  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSreadonly.h:82:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.h:89:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.h:30:  Extra space between class and JSTestCustomNamedGetter  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.h:89:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSattribute.h:83:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSattribute.h:31:  Extra space between class and JSattribute  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSattribute.h:83:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:88:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:32:  Extra space between class and JSTestSerializedScriptValueInterface  [whitespace/declaration] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:88:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 45 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 252992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252992&action=review

r=me, please fix the extra spaces

> Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h:30
> +class  JSTestActiveDOMObject : public JSDOMWrapper {

Too many spaces

> Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h:85
> + JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, TestActiveDOMObject*);

One extra space at the start

> Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.h:89
> + JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, TestCustomNamedGetter*);

Here too

> Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h:32
> +class  JSTestEventConstructor : public JSDOMWrapper {

again

> Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h:30
> +class  JSTestEventTarget : public JSDOMWrapper {

…

[Alex Christensen]

Created attachment 253000 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/changeset/184228

[Alex Christensen]

rdar://problem/20899034

[Ryosuke Niwa]

Landed a build fix in https://trac.webkit.org/changeset/184234.