Bug 14271 - Add preferences key to make the inspector dock by default
Summary: Add preferences key to make the inspector dock by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.5
: P3 Enhancement
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
: 26468 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-06-21 00:08 PDT by Matt Lilek
Modified: 2009-07-10 19:45 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (8.90 KB, patch)
2008-08-13 07:48 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Windows Patch (3.98 KB, patch)
2009-07-09 17:54 PDT, Brian Weinstein 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2007-06-21 00:08:01 PDT 
There should be a preferences key or some other way to have the inspector dock to the webview when shown by default instead of having to open it then manually dock it.
Comment 1 Adam Roben (:aroben) 2008-01-29 11:15:05 PST 
<rdar://problem/5712929>
Comment 2 Timothy Hatcher 2008-08-13 07:48:07 PDT 
Created attachment 22773 [details]
Proposed patch
Comment 3 Kevin McCullough 2008-08-13 10:47:25 PDT 
Comment on attachment 22773 [details]
Proposed patch

InspectorController.h
Line 108: "attached" default is false.  Will this open the inspector docked by default?

Please make the windows side of this or file another bug for just that part.
Comment 4 Timothy Hatcher 2008-08-13 10:54:20 PDT 
(In reply to comment #3)
> (From update of attachment 22773 [details] [edit])
> InspectorController.h
> Line 108: "attached" default is false.  Will this open the inspector docked by
> default?

No, the WebKit code passed a value for the attached argument. WebKit decides to open by default or not.
Comment 5 Timothy Hatcher 2008-08-13 11:35:21 PDT 
Landed in r35722.
Comment 6 Adam Roben (:aroben) 2009-07-01 13:57:44 PDT 
*** Bug 26468 has been marked as a duplicate of this bug. ***
Comment 7 Brian Weinstein 2009-07-09 17:54:55 PDT 
Created attachment 32544 [details]
Windows Patch
Comment 8 Maciej Stachowiak 2009-07-10 18:18:36 PDT 
Comment on attachment 32544 [details]
Windows Patch

r=me

In the future please try to avoid attaching patches to closed bugs. File a new bug instead.
Comment 9 Brian Weinstein 2009-07-10 18:19:59 PDT 
Maciej, I filed a new bug at https://bugs.webkit.org/show_bug.cgi?id=27140 yesterday, I should have put a comment here when I did. Sorry about that.