Bug 27140 – Add a preference key to make Web Inspector detach/attach by default

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Brian Weinstein]

There should be a preferences key or some other way to have the inspector dock
to the webview when shown by default instead of having to open it then manually
dock it (Windows version).

<rdar://5712929>

[Brian Weinstein]

Created attachment 32545 [details]
Windows Patch

[Alice Liu]

Comment on attachment 32545 [details]
Windows Patch

> @@ -322,6 +324,9 @@ void WebInspectorClient::showWindowWitho
>      ASSERT(m_webView);
>      ASSERT(m_inspectedWebViewHwnd);
>  
> +    InspectorController::Setting shouldAttach = m_inspectedWebView->page()->inspectorController()->setting(inspectorStartsAttachedName);
> +    m_shouldAttachWhenShown = (shouldAttach.type() == InspectorController::Setting::BooleanType) ? shouldAttach.booleanValue() : false;
> +
>      if (!m_shouldAttachWhenShown) {
>          // Put the Inspector's WebView inside our window and show it.
>          m_webView->setHostWindow(reinterpret_cast<OLE_HANDLE>(m_hwnd));

bdash wants you to remove the extraneous parents around the condition before the question mark

r=me

[Brian Weinstein]

Committed in revision 45689.

[Adam Roben (:aroben)]

Comment on attachment 32545 [details]
Windows Patch

I think it's a shame that all this work was done up at the WebKit level. (Almost?) All of this code should be cross-platform, instead of duplicated between Mac (in bug 27141) and Windows. I'd really like to see this moved down into WebCore.

[Adam Roben (:aroben)]

(In reply to comment #4)
> (From update of attachment 32545 [details])
> I think it's a shame that all this work was done up at the WebKit level.
> (Almost?) All of this code should be cross-platform, instead of duplicated
> between Mac (in bug 27141) and Windows. I'd really like to see this moved down
> into WebCore.

It is great to have the bug fixed, though!