As a first step towards integration of OpenWebRTC on the platform layer it'd be good to add it in JHBuild and CMake stuff.
We will need to make sure MEDIA_STREAM build is disabled in the release tarballs for now because the mediastream audio/video rendering module will depend on a non-upstream version of OpenWebRTC. However I think this feature should remain enabled in developer builds and on the buildbots :)
Created attachment 248064 [details] patch
It seems gst-plugins-openwebrtc failed to build for whatever reason. Btw, I'm not happy using downstream forks as dependencies (I prefer to use upstream repos and add the patches required by WebKit), but I guess this is a temporary thing.
Of course it is temporary. I'll try to figure out what's up with the EWS.
Created attachment 248235 [details] patch
Created attachment 248520 [details] patch
Created attachment 248521 [details] patch
Created attachment 248717 [details] patch
Created attachment 248719 [details] patch EWS all over again
Created attachment 248720 [details] patch lalala
Created attachment 248723 [details] patch
Green EWS is green. Can this be reviewed now? :)
Comment on attachment 248723 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=248723&action=review > Tools/gtk/jhbuild.modules:384 > + <autotools id="libnice"> > + <dependencies> > + <dep package="gstreamer"/> > + </dependencies> > + <branch repo="freedesktop-git" module="libnice/libnice.git" tag="0.1.10" checkoutdir="libnice"/> > + </autotools> I guess we need this here, because the version that can be installed in the bots is not recent enough, right?
(In reply to comment #13) > Comment on attachment 248723 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248723&action=review > > > Tools/gtk/jhbuild.modules:384 > > + <autotools id="libnice"> > > + <dependencies> > > + <dep package="gstreamer"/> > > + </dependencies> > > + <branch repo="freedesktop-git" module="libnice/libnice.git" tag="0.1.10" checkoutdir="libnice"/> > > + </autotools> > > I guess we need this here, because the version that can be installed in the > bots is not recent enough, right? Typically these types of dependencies go into jhbuild-optional.modules.
(In reply to comment #14) > (In reply to comment #13) > > Comment on attachment 248723 [details] > > patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=248723&action=review > > > > > Tools/gtk/jhbuild.modules:384 > > > + <autotools id="libnice"> > > > + <dependencies> > > > + <dep package="gstreamer"/> > > > + </dependencies> > > > + <branch repo="freedesktop-git" module="libnice/libnice.git" tag="0.1.10" checkoutdir="libnice"/> > > > + </autotools> > > > > I guess we need this here, because the version that can be installed in the > > bots is not recent enough, right? > Right, the one I have here in Debian is 0.1.7 but configure.ac requires 0.1.7.1 or greater. > Typically these types of dependencies go into > jhbuild-optional.modules. By these you mean openwebrtc as well? I'm afraid it will be needed to run the layout tests though.
Committed r181624: <http://trac.webkit.org/changeset/181624>