RESOLVED FIXED 141413
stop using WebCore.exp.in 
https://bugs.webkit.org/show_bug.cgi?id=141413
Summary stop using WebCore.exp.in
Alex Christensen
Reported 2015-02-09 16:46:07 PST
This is the minimal patch to make the switch. I'll remove WebCore.exp.in, the build steps involved with it, and the style checking of it in a later patch cleaning up. This will make it easier to revert in case this causes any problems.
Attachments
Patch (2.74 KB, patch)
2015-02-09 16:50 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.74 KB, patch)
2015-02-09 17:24 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.69 KB, patch)
2015-02-10 15:10 PST, Alex Christensen 		dbates: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-02-09 16:50:49 PST
Created attachment 246305 [details] Patch
Alex Christensen
Comment 2 2015-02-09 17:24:12 PST
Created attachment 246306 [details] Patch
Alex Christensen
Comment 3 2015-02-10 15:10:02 PST
Created attachment 246345 [details] Patch
Alex Christensen
Comment 4 2015-02-10 16:02:32 PST
https://trac.webkit.org/r179896
Alex Christensen
Comment 5 2015-02-10 16:03:26 PST
https://trac.webkit.org/r179896
WebKit Commit Bot
Comment 6 2015-02-10 17:37:28 PST
Re-opened since this is blocked by bug 141452
Darin Adler
Comment 7 2015-02-10 23:20:02 PST
Comment on attachment 246345 [details] Patch We shouldn’t make this change before inspecting the differences between what is exported before and after the change. Could you post the list of differences between what is exported by WebCore.framework before and after on at least one platform? (Release, not debug.)
Alex Christensen
Comment 8 2015-02-11 11:18:48 PST
As of 179931, the only difference between the exports of the WebCore framework on Mavericks with this patch is that these two symbols are no longer exported: _wkCreateURLNPasteboardFlavorTypeName _wkCreateURLPasteboardFlavorTypeName They're not used anywhere, so I think there is no problem making the change.
Alex Christensen
Comment 9 2015-02-11 12:30:45 PST
Recommitted to https://trac.webkit.org/r179945
Darin Adler
Comment 10 2015-02-11 12:41:43 PST
(In reply to comment #8) > As of 179931, the only difference between the exports of the WebCore > framework on Mavericks with this patch is that these two symbols are no > longer exported: > > _wkCreateURLNPasteboardFlavorTypeName > _wkCreateURLPasteboardFlavorTypeName > > They're not used anywhere, so I think there is no problem making the change. Good news!
Darin Adler
Comment 11 2015-02-11 12:42:27 PST
Can we follow up by deleting the various WebCore.exp.in files and the sort-export-files scripts?
Alex Christensen
Comment 12 2015-02-11 12:43:45 PST
(In reply to comment #11) > Can we follow up by deleting the various WebCore.exp.in files and the > sort-export-files scripts? That's the next step, along with removing the build step of processing WebCore.exp.in. I'll wait a few hours in case this needs to be reverted again for some reason. Then on to Windows!
Note You need to log in before you can comment on or make changes to this bug.