Bug 141430 - iOS needs more WEBCORE_EXPORT macros
Summary: iOS needs more WEBCORE_EXPORT macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks: 141413
  Show dependency tree / graph
 
Reported: 2015-02-10 06:15 PST by Alex Christensen
Modified: 2015-02-10 16:20 PST (History)
0 users

See Also:

Attachments
Patch (19.66 KB, patch)
2015-02-10 06:33 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (17.88 KB, patch)
2015-02-10 14:43 PST, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-02-10 06:15:50 PST 
I've noted where I'm not sure I should be using WEBCORE_EXPORT macros.  Maybe I should use __attribute__((visibility("default"))) directly?  Maybe there's a better way to export some of these?
Comment 1 Alex Christensen 2015-02-10 06:33:17 PST 
Created attachment 246321 [details]
Patch
Comment 2 Alex Christensen 2015-02-10 14:43:54 PST 
Created attachment 246341 [details]
Patch
Comment 3 Alex Christensen 2015-02-10 15:08:34 PST 
http://trac.webkit.org/changeset/179886
Comment 4 Alex Christensen 2015-02-10 16:20:21 PST 
bindings tests fixed in https://trac.webkit.org/r179903
oops