RESOLVED FIXED 141164
run-jsc-stress-tests should pass JSC_timeout to remote hosts 
https://bugs.webkit.org/show_bug.cgi?id=141164
Summary run-jsc-stress-tests should pass JSC_timeout to remote hosts
Csaba Osztrogonác
Reported 2015-02-02 11:01:53 PST
SSIA
Attachments
Patch (2.59 KB, patch)
2015-02-02 11:06 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-02-02 11:06:17 PST
Created attachment 245886 [details] Patch
Mark Hahnenberg
Comment 2 2015-02-03 09:56:19 PST
Comment on attachment 245886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245886&action=review > Tools/Scripts/run-jsc-stress-tests:1364 > + remoteScript += "export DYLD_FRAMEWORK_PATH=\\\"\\$(cd #{$testingFrameworkPath.dirname}; pwd)\\\" && " > + remoteScript += "export JSC_timeout=#{Shellwords.shellescape(ENV['JSC_timeout'])} && " > + remoteScript += "sh runscript\"" I think if you're going to export these you should also unset them after executing the runscript or something.
Csaba Osztrogonác
Comment 3 2015-02-03 10:06:29 PST
(In reply to comment #2) > Comment on attachment 245886 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245886&action=review > > > Tools/Scripts/run-jsc-stress-tests:1364 > > + remoteScript += "export DYLD_FRAMEWORK_PATH=\\\"\\$(cd #{$testingFrameworkPath.dirname}; pwd)\\\" && " > > + remoteScript += "export JSC_timeout=#{Shellwords.shellescape(ENV['JSC_timeout'])} && " > > + remoteScript += "sh runscript\"" > > I think if you're going to export these you should also unset them after > executing the runscript or something. These exports are valid for this ssh command and its child processes, they are reset automatically after the command finished.
Csaba Osztrogonác
Comment 4 2015-02-07 23:06:36 PST
ping?
Csaba Osztrogonác
Comment 5 2015-02-11 06:35:46 PST
Dear reviewers, could you possibly review this patch?
WebKit Commit Bot
Comment 6 2015-02-11 09:10:18 PST
Comment on attachment 245886 [details] Patch Clearing flags on attachment: 245886 Committed r179930: <http://trac.webkit.org/changeset/179930>
WebKit Commit Bot
Comment 7 2015-02-11 09:10:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.