run-jsc-stress-tests should pass JSC_timeout to remote hosts

[Csaba Osztrogonác]

SSIA

[Csaba Osztrogonác]

Created attachment 245886 [details]
Patch

[Mark Hahnenberg]

Comment on attachment 245886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245886&action=review

> Tools/Scripts/run-jsc-stress-tests:1364
> +        remoteScript += "export DYLD_FRAMEWORK_PATH=\\\"\\$(cd #{$testingFrameworkPath.dirname}; pwd)\\\" && "
> +        remoteScript += "export JSC_timeout=#{Shellwords.shellescape(ENV['JSC_timeout'])} && "
> +        remoteScript += "sh runscript\""

I think if you're going to export these you should also unset them after executing the runscript or something.

[Csaba Osztrogonác]

(In reply to comment #2)
> Comment on attachment 245886 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245886&action=review
> 
> > Tools/Scripts/run-jsc-stress-tests:1364
> > +        remoteScript += "export DYLD_FRAMEWORK_PATH=\\\"\\$(cd #{$testingFrameworkPath.dirname}; pwd)\\\" && "
> > +        remoteScript += "export JSC_timeout=#{Shellwords.shellescape(ENV['JSC_timeout'])} && "
> > +        remoteScript += "sh runscript\""
> 
> I think if you're going to export these you should also unset them after
> executing the runscript or something.

These exports are valid for this ssh command and its child 
processes, they are reset automatically after the command finished.

[Csaba Osztrogonác]

ping?

[Csaba Osztrogonác]

Dear reviewers, could you possibly review this patch?

[WebKit Commit Bot]

Comment on attachment 245886 [details]
Patch

Clearing flags on attachment: 245886

Committed r179930: <http://trac.webkit.org/changeset/179930>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.