Bug 141079 - Make run-jsc-stress-tests --remote work with make-based runner
Summary: Make run-jsc-stress-tests --remote work with make-based runner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on: 141164 141196
Blocks: 141165
  Show dependency treegraph
 
Reported: 2015-01-30 05:25 PST by Csaba Osztrogonác
Modified: 2015-02-11 12:31 PST (History)
9 users (show)

See Also:


Attachments
WIP patch (4.17 KB, patch)
2015-01-30 05:37 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (12.36 KB, patch)
2015-02-03 09:27 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (2.60 KB, patch)
2015-02-03 09:30 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (6.79 KB, patch)
2015-02-03 09:32 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (6.79 KB, patch)
2015-02-11 09:54 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-01-30 05:25:45 PST
run-jsc-stress-tests supports a make-based runner and a shell-based runner.

For local run both of them are supported. The goal is to make the make-based 
runner work (optionally) for remote testing too. It is much more faster than
the shell-based runner and make is available on Linux, we can use it.
Comment 1 Csaba Osztrogonác 2015-01-30 05:37:35 PST
Created attachment 245713 [details]
WIP patch
Comment 2 Csaba Osztrogonác 2015-01-30 05:43:18 PST
Comment on attachment 245713 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245713&action=review

> Tools/Scripts/run-jsc-stress-tests:-191
>      when '--remote'
>          $copyVM = true
> -        $testRunnerType = :shell

Now the default runner type is shell, which is good for iOS, but bad for Linux.
But with this change, the default is make, which is good for Linux, but bad for iOS.

I'm going to find a good way to have different default runner types based on OS
or add some autodetection mechanism: use make if it is available, otherwise use shell.

> Tools/Scripts/run-jsc-stress-tests:1408
> +        remoteScript += "DYLD_FRAMEWORK_PATH=\\\"\\$(cd #{$testingFrameworkPath.dirname}; pwd)\\\" make -j4 -s -f Makefile"

I'm going to find how to detect / set number of parallel tasks properly instead of hard coding.
Comment 3 Csaba Osztrogonác 2015-02-03 08:39:19 PST
new bug report for processor number detection: bug141196
Comment 4 Csaba Osztrogonác 2015-02-03 09:27:49 PST
Created attachment 245943 [details]
Patch

Complete patch, it depends on fix in bug141196 and bug141164. I'll set r? once these fixes landed.
Comment 5 Csaba Osztrogonác 2015-02-03 09:28:24 PST
Comment on attachment 245943 [details]
Patch

wrong patch
Comment 6 Csaba Osztrogonác 2015-02-03 09:30:54 PST
Created attachment 245944 [details]
Patch
Comment 7 Csaba Osztrogonác 2015-02-03 09:31:27 PST
Comment on attachment 245944 [details]
Patch

webkit-patch upload is crazy :-/
Comment 8 Csaba Osztrogonác 2015-02-03 09:32:25 PST
Created attachment 245945 [details]
Patch
Comment 9 Csaba Osztrogonác 2015-02-11 09:54:31 PST
Created attachment 246394 [details]
Patch
Comment 10 WebKit Commit Bot 2015-02-11 12:31:30 PST
Comment on attachment 246394 [details]
Patch

Clearing flags on attachment: 246394

Committed r179946: <http://trac.webkit.org/changeset/179946>
Comment 11 WebKit Commit Bot 2015-02-11 12:31:34 PST
All reviewed patches have been landed.  Closing bug.