Bug 140053 – Web Inspector: purge PassRefPtr from Inspector code and use Ref for typed and untyped protocol objects

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brian Burg]

Patch forthcoming.

[Radar WebKit Bug Importer]

<rdar://problem/19370241>

[Brian Burg]

Created attachment 244000 [details]
Patch

Attached patch does not apply to ToT yet. Please review anyway, I will upload another patch until EWS runs cleanly.

[Joseph Pecoraro]

Did you r+ your own patch?

[Brian Burg]

Comment on attachment 244000 [details]
Patch

Doh, wrong button. Was running out the door. Thanks Joe.

[Andreas Kling]

Comment on attachment 244000 [details]
Patch

This looks very good to me. You should upload a new version for EWS once the dependencies have landed.

[Brian Burg]

Created attachment 244096 [details]
Patch for EWS

[WebKit Commit Bot]

This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

[WebKit Commit Bot]

Attachment 244096 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:547:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:190:  out_optionalValueFound is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/page/PageConsoleClient.h:59:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 3 in 122 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brian Burg]

Created attachment 244125 [details]
EWS round 2

[Brian Burg]

Created attachment 244128 [details]
EWS round 3

[WebKit Commit Bot]

Attachment 244128 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:547:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:190:  out_optionalValueFound is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/page/PageConsoleClient.h:59:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 3 in 124 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brian Burg]

Committed r178039: <http://trac.webkit.org/changeset/178039>

will be watching bots for next few hours in case any surprises.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 140187

[Joseph Pecoraro]

Created attachment 244205 [details]
[PATCH] ObjC side fixes

These were the fixes to the generate necessary for the ObjC code changes. Brian, do these look good to you? If so, I can re-land your patch, with these changes, and with the Internal side of this (PassRefPtr -> RefPtr&& necessary changes).

[Joseph Pecoraro]

http://trac.webkit.org/changeset/178060

[Alexey Proskuryakov]

Comment on attachment 244128 [details]
EWS round 3

View in context: https://bugs.webkit.org/attachment.cgi?id=244128&action=review

> Source/WebCore/page/PageConsoleClient.cpp:156
> -        ConsoleClient::printConsoleMessageWithArguments(MessageSource::ConsoleAPI, type, level, exec, arguments.release());
> +        ConsoleClient::printConsoleMessageWithArguments(MessageSource::ConsoleAPI, type, level, exec, WTF::move(arguments));

This cannot work, we already moved out of arguments a few lines above.