Bug 140002 - Web Inspector: pass parameters to inspector agents by reference where possible
Summary: Web Inspector: pass parameters to inspector agents by reference where possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks: 140053
  Show dependency tree / graph
 
Reported: 2014-12-29 19:03 PST by Brian Burg
Modified: 2015-01-06 13:45 PST (History)
8 users (show)

See Also:

Attachments
Patch (95.07 KB, patch)
2015-01-05 13:42 PST, Brian Burg 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-12-29 19:03:52 PST 
More cleanup. Push references another level down.
Comment 1 Radar WebKit Bug Importer 2014-12-29 19:04:20 PST 
<rdar://problem/19358093>
Comment 2 Brian Burg 2015-01-05 13:42:55 PST 
Created attachment 243999 [details]
Patch
Comment 3 WebKit Commit Bot 2015-01-05 13:45:01 PST 
Attachment 243999 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/InspectorResourceAgent.h:92:  The parameter name "loader" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andreas Kling 2015-01-06 12:44:44 PST 
Comment on attachment 243999 [details]
Patch

r=me
Comment 5 Brian Burg 2015-01-06 13:45:07 PST 
Committed r177993: <http://trac.webkit.org/changeset/177993>