Bug 140187 – REGRESSION(r178039): Breaks ObjC Inspector Protocol (Requested by JoePeck on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Commit Bot]

http://trac.webkit.org/changeset/178039 broke the build:
Breaks ObjC Inspector Protocol (Requested by JoePeck on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 244170 [details]
ROLLOUT of r178039

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Joseph Pecoraro]

Comment on attachment 244170 [details]
ROLLOUT of r178039

I will be looking into fixing the ObjC stuff today so that this can land again.

[WebKit Commit Bot]

This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

[WebKit Commit Bot]

Comment on attachment 244170 [details]
ROLLOUT of r178039

Clearing flags on attachment: 244170

Committed r178042: <http://trac.webkit.org/changeset/178042>

[WebKit Commit Bot]

Attachment 244170 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:759:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:770:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.cpp:1210:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:67:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:139:  The parameter name "style" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:153:  The parameter name "style" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:219:  The parameter name "style" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:221:  The parameter name "style" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:225:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:225:  The parameter name "inspectorStyle" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:226:  The parameter name "style" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:278:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorDatabaseResource.h:48:  The parameter name "database" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:926:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:927:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:55:  whitespace before ']'  [pep8/E202] [5]
Total errors found: 17 in 125 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.