Alexey Proskuryakov 2014-12-19 00:34:28 PST I now think that the cleanest fix would be to set is_clean in these two before calling Factory.__init__. With this, CleanBuildIfScheduled would clean the directory at the right time. Comment 5 Ryosuke Niwa 2014-12-19 00:37:43 PST Or pass in --no-build to run-perf-tests...
Created attachment 243554 [details] proposed patch
Comment on attachment 243554 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=243554&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:711 > + # FIXME: Can all ports use --no-build? Everything appears to be either downloaded > + # or built locally before running this step. > + if platform == 'mac': > + self.setCommand(self.command + ['--no-build']) We can do it unconditionally, EFL and GTK build everything it one shot, build-webkittestrunner simply returns 0 without doing anything.
Comment on attachment 243554 [details] proposed patch r=me with the change suggested.
Committed <http://trac.webkit.org/r177575>. We'll need to see if this affects what happens when builds are broken in any strange ways. Seems like it shouldn't though.