Bug 139786 - Perf tests frequently fail saying "build not up to date"
Summary: Perf tests frequently fail saying "build not up to date"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on: 139811
Blocks:
  Show dependency tree / graph
 
Reported: 2014-12-18 12:10 PST by Alexey Proskuryakov
Modified: 2014-12-19 09:42 PST (History)
4 users (show)

See Also:

Attachments
proposed fix (4.24 KB, patch)
2014-12-18 12:17 PST, Alexey Proskuryakov 		rniwa: review+
Details | Formatted Diff | Diff
proposed re-fix (4.99 KB, patch)
2014-12-18 15:14 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-12-18 12:10:39 PST 
E.g.:

https://build.webkit.org/builders/Apple%20MountainLion%20Release%20%28Perf%29/builds/10909/steps/perf-test/logs/stdio

CompileC /Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/Objects-normal/x86_64/EditingDelegate.o mac/EditingDelegate.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
    cd /Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/DumpRenderTree
    export LANG=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu++11 -stdlib=libc++ -Wno-trigraphs -fno-rtti -fpascal-strings -Os -Werror -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-return-type -Wno-implicit-atomic-properties -Wno-receiver-is-weak -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wno-undeclared-selector -Wno-deprecated-implementations -Wno-c++11-extensions -DNDEBUG -DENABLE_DASHBOARD_SUPPORT -DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wno-deprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.8 -g -Wno-sign-conversion -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/DumpRenderTree.hmap -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/Release/include -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/Release/usr/local/include -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/Release/WebCoreTestSupport -IForwardingHeaders -Imac/InternalHeaders -I/usr/local/include/WebCoreTestSupport -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/DumpRenderTree/../../Source/JavaScriptCore/icu -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/DerivedSources/x86_64 -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/DerivedSources -Wall -W -Wno-unused-parameter -Wundef -F/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/Release -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/Quartz.framework/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/ApplicationServices.framework/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/WebKit.framework/Frameworks -include /Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/PrecompiledHeaders/DumpRenderTreePrefix-eznzwvgtqfndrdhafdiqkocjvhoa/DumpRenderTreePrefix.h -MMD -MT dependencies -MF /Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/Objects-normal/x86_64/EditingDelegate.d --serialize-diagnostics /Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/Objects-normal/x86_64/EditingDelegate.dia -c /Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/DumpRenderTree/mac/EditingDelegate.mm -o /Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/Objects-normal/x86_64/EditingDelegate.o
fatal error: file '/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/Release/usr/local/include/wtf/FeatureDefines.h' has been modified since the precompiled header '/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/PrecompiledHeaders/DumpRenderTreePrefix-eznzwvgtqfndrdhafdiqkocjvhoa/DumpRenderTreePrefix.h.pch' was built
1 error generated.
Comment 1 Alexey Proskuryakov 2014-12-18 12:17:17 PST 
Created attachment 243512 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2014-12-18 14:51:50 PST 
Committed <http://trac.webkit.org/r177529>.
Comment 3 Alexey Proskuryakov 2014-12-18 15:07:57 PST 
Comment on attachment 243512 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=243512&action=review

> Tools/ChangeLog:12
> +        Also, removed unused "build and perf test" code.

This were actually used, just under a different name (string manipulation for class name === evil). Rolled out this part in r177533.
Comment 4 Alexey Proskuryakov 2014-12-18 15:12:12 PST 
More fixes needed.
Comment 5 Alexey Proskuryakov 2014-12-18 15:14:39 PST 
Created attachment 243523 [details]
proposed re-fix
Comment 6 Lucas Forschler 2014-12-18 15:17:20 PST 
looks good to me.
Comment 7 Alexey Proskuryakov 2014-12-18 15:22:59 PST 
Committed <http://trac.webkit.org/r177535>.
Comment 8 Ryosuke Niwa 2014-12-18 15:37:48 PST 
Retroactively r=me.