Bug 139811 – REGRESSION(r177535): It broke the GTK performance bot

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

After http://trac.webkit.org/r177535 performance bots remove 
WebKitBuild directory unconditionally. It was a workaround to
fix a Mac only issue, but it broke the GTK bot:
https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Perf%29/builds/1522
5.) jhbuild updated gtk dependencies 
6.) delete WebKitBuild directory_1 deleted WebKitBuild directory 
--> It removes the necessary dependencies built by step 5.)

This clean build is incorrect and unnecessary on the GTK bot.

[Csaba Osztrogonác]

Created attachment 243547 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 243547 [details]
Patch

Clearing flags on attachment: 243547

Committed r177569: <http://trac.webkit.org/changeset/177569>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

I now think that the cleanest fix would be to set is_clean in these two before calling Factory.__init__. With this, CleanBuildIfScheduled would clean the directory at the right time.

[Ryosuke Niwa]

Or pass in --no-build to run-perf-tests...

[Csaba Osztrogonác]

(In reply to comment #2)
> Comment on attachment 243547 [details]
> Patch
> 
> Clearing flags on attachment: 243547
> 
> Committed r177569: <http://trac.webkit.org/changeset/177569>

Lucas or Ryosuke, could you possibly push this change to buildmaster
and then restart to fix the GTK performance bot? Thanks.

[Lucas Forschler]

I've restarted the master, let me know if things don't look correct.

[Csaba Osztrogonác]

(In reply to comment #7)
> I've restarted the master, let me know if things don't look correct.

Thanks, the GTK performance bot is happy now. :)

[Darin Adler]

Comment on attachment 243547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243547&action=review

> Tools/ChangeLog:8
> +        Trigger clean build only on mac platform.

Why? If the problem is on GTK, then why isn’t the condition here about GTK, rather than Mac?

[Darin Adler]

Comment on attachment 243547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243547&action=review

>> Tools/ChangeLog:8
>> +        Trigger clean build only on mac platform.
> 
> Why? If the problem is on GTK, then why isn’t the condition here about GTK, rather than Mac?

I guess it’s not an important question; looks like Alexey removed this code a few commits later.