Bug 138510 - Fix an alignment issue with operationPushCatchScope on ARMv7
Summary: Fix an alignment issue with operationPushCatchScope on ARMv7
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 138254
Blocks: 108645
  Show dependency treegraph
Reported: 2014-11-07 11:42 PST by Dániel Bátyai
Modified: 2014-11-08 03:03 PST (History)
3 users (show)

See Also:

Patch (2.95 KB, patch)
2014-11-07 11:47 PST, Dániel Bátyai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dániel Bátyai 2014-11-07 11:42:57 PST
A previous patch caused a regression on some ARMv7 platforms.
Call arguments were set up differently than how the callee expected them.
Comment 1 Dániel Bátyai 2014-11-07 11:47:10 PST
Created attachment 241196 [details]
Comment 2 Csaba Osztrogonác 2014-11-07 12:18:02 PST
Comment on attachment 241196 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=241196&action=review

r=me , but CQ-, because it depends on bug138254

> Source/JavaScriptCore/jit/JITInlines.h:586
> -    setupArgumentsWithExecState(TrustedImm32(op1), TrustedImmPtr(identOp2), regOp3Payload, regOp3Tag, TrustedImm32(op4));
> +    setupArgumentsWithExecState(TrustedImm32(op1), TrustedImmPtr(identOp2), EABI_32BIT_DUMMY_ARG regOp3Payload, regOp3Tag, TrustedImm32(op4));

Good catch, ARM EABI doesn't like splitting the 64 bit sized JSValue to r3 and stack.
Comment 3 WebKit Commit Bot 2014-11-07 15:36:20 PST
Comment on attachment 241196 [details]

Clearing flags on attachment: 241196

Committed r175766: <http://trac.webkit.org/changeset/175766>
Comment 4 WebKit Commit Bot 2014-11-07 15:36:23 PST
All reviewed patches have been landed.  Closing bug.