Bug 138254 - Update scope related slow path code to use scope register added to opcodes
Summary: Update scope related slow path code to use scope register added to opcodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on: 138252 138349
Blocks: 136724 138510
  Show dependency tree / graph
 
Reported: 2014-10-31 11:12 PDT by Michael Saboff
Modified: 2014-11-07 13:58 PST (History)
5 users (show)

See Also:

Attachments
Patch (23.04 KB, patch)
2014-11-03 17:53 PST, Michael Saboff 		mark.lam: review+
Details | Formatted Diff | Diff
buildfix for ARMv7 (1.38 KB, patch)
2014-11-04 00:23 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
JSC test log from ARMv7 Thumb2 (3.36 MB, application/octet-stream)
2014-11-04 01:22 PST, Csaba Osztrogonác 		no flags Details
Patch updated with supplied build fixes. (24.18 KB, patch)
2014-11-04 14:05 PST, Michael Saboff 		mark.lam: review+
Details | Formatted Diff | Diff
minimal example to debug (120 bytes, application/x-javascript)
2014-11-05 02:45 PST, Csaba Osztrogonác 		no flags Details
log on r175612 without patch (310.93 KB, text/plain)
2014-11-05 03:06 PST, Csaba Osztrogonác 		no flags Details
log on r175612 with patch applied (310.94 KB, text/plain)
2014-11-05 03:07 PST, Csaba Osztrogonác 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-10-31 11:12:07 PDT 
Update the slow paths to use the scope operands added in <https://bugs.webkit.org/show_bug.cgi?id=138252> and <https://bugs.webkit.org/show_bug.cgi?id=138253>
Comment 1 Michael Saboff 2014-11-03 17:53:49 PST 
Created attachment 240892 [details]
Patch
Comment 2 Mark Lam 2014-11-03 19:22:41 PST 
Comment on attachment 240892 [details]
Patch

r=me
Comment 3 Michael Saboff 2014-11-03 19:53:11 PST 
Committed r175509: <http://trac.webkit.org/changeset/175509>
Comment 4 Chris Dumez 2014-11-03 20:05:03 PST 
Some bots seems to have trouble building after this change:
https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Thumb2%20Release%20%28Build%29/builds/8038/steps/compile-webkit/logs/stdio
Comment 5 WebKit Commit Bot 2014-11-03 20:55:18 PST 
Re-opened since this is blocked by bug 138349
Comment 6 Csaba Osztrogonác 2014-11-04 00:23:31 PST 
Created attachment 240917 [details]
buildfix for ARMv7

This patch fixed the ARMv7 Thumb2 Linux build for me, but got some regressions.
I'll upload the detailed results soon. (tests still running)
Comment 7 Csaba Osztrogonác 2014-11-04 01:22:16 PST 
Created attachment 240918 [details]
JSC test log from ARMv7 Thumb2
Comment 8 Michael Saboff 2014-11-04 14:03:55 PST 
(In reply to comment #7)
> Created attachment 240918 [details]
> JSC test log from ARMv7 Thumb2

Thanks for the build fix.  I added it to the original patch and ran tests on ARMv7 Thumb2.  I do not see the failures you are seeing.  I'm going to post the combined patch.

Could you clean build, rerun test and report back with the results?
Comment 9 Michael Saboff 2014-11-04 14:05:33 PST 
Created attachment 240946 [details]
Patch updated with supplied build fixes.

Will run through the EWS bots before landing.
Comment 10 Csaba Osztrogonác 2014-11-05 01:29:48 PST 
(In reply to comment #8)
> (In reply to comment #7)
> > Created attachment 240918 [details]
> > JSC test log from ARMv7 Thumb2
> 
> Thanks for the build fix.  I added it to the original patch and ran tests on
> ARMv7 Thumb2.  I do not see the failures you are seeing.  I'm going to post
> the combined patch.
> 
> Could you clean build, rerun test and report back with the results?

I tried it, the build works fine, but unfortunately the failures 
is still present on Linux with Thumb2 and ARM instruction set too.
Comment 11 Csaba Osztrogonác 2014-11-05 02:45:51 PST 
Created attachment 241015 [details]
minimal example to debug

$ ./jsc --useLLInt=false --useDFGJIT=false -f foo.js
1.9097962116e-313

expected result: foo_string
Comment 12 Csaba Osztrogonác 2014-11-05 03:06:45 PST 
Created attachment 241017 [details]
log on r175612 without patch

$ ./jsc --useLLInt=false --useDFGJIT=false --dumpGeneratedBytecodes=true --showDisassembly=true -f foo.js
Comment 13 Csaba Osztrogonác 2014-11-05 03:07:24 PST 
Created attachment 241018 [details]
log on r175612 with patch applied
Comment 14 Michael Saboff 2014-11-07 06:46:21 PST 
(In reply to comment #13)
> Created attachment 241018 [details]
> log on r175612 with patch applied

I'll look at the generated assembly today to see what is going on.
Comment 15 Dániel Bátyai 2014-11-07 06:52:10 PST 
(In reply to comment #14)
> (In reply to comment #13)
> > Created attachment 241018 [details]
> > log on r175612 with patch applied
> 
> I'll look at the generated assembly today to see what is going on.

Hi, we have found the issue already, patch is on the way.
Comment 16 Csaba Osztrogonác 2014-11-07 12:20:05 PST 
(In reply to comment #15)
> (In reply to comment #14)
> > (In reply to comment #13)
> > > Created attachment 241018 [details]
> > > log on r175612 with patch applied
> > 
> > I'll look at the generated assembly today to see what is going on.
> 
> Hi, we have found the issue already, patch is on the way.

Dániel already fixed the issue in bug138510. It's safe 
to land this one and then the fix from bug138510.
Comment 17 Mark Lam 2014-11-07 13:32:29 PST 
Comment on attachment 240946 [details]
Patch updated with supplied build fixes.

r=me
Comment 18 Michael Saboff 2014-11-07 13:58:34 PST 
Committed r175762: <http://trac.webkit.org/changeset/175762>