RESOLVED FIXED 137445
[GTK][Stable] webkitgtk-2.4.6: fails to build with --disable-video 
https://bugs.webkit.org/show_bug.cgi?id=137445
Summary [GTK][Stable] webkitgtk-2.4.6: fails to build with --disable-video
Pacho Ramos
Reported 2014-10-06 02:11:17 PDT
And this error: In file included from ./Source/WTF/wtf/Platform.h:636:0, from ./Source/JavaScriptCore/config.h:30, from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26: ./Source/WTF/wtf/FeatureDefines.h:880:2: error: #error "ENABLE(VIDEO_TRACK) requires ENABLE(VIDEO)" #error "ENABLE(VIDEO_TRACK) requires ENABLE(VIDEO)" ^ Looks similar to: https://bugs.webkit.org/show_bug.cgi?id=121259 And could be caused by this change: https://bugs.webkit.org/show_bug.cgi?id=134801 Full build.log is at: https://bugs.gentoo.org/attachment.cgi?id=386082 From downstream report: https://bugs.gentoo.org/show_bug.cgi?id=524518 Thanks
Attachments
patch (55 bytes, text/plain)
2014-10-08 13:46 PDT, Pacho Ramos 		no flags
Details
patch (834 bytes, patch)
2014-10-08 13:47 PDT, Pacho Ramos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pacho Ramos
Comment 1 2014-10-08 07:23:57 PDT
Patch attached to: https://bugs.gentoo.org/show_bug.cgi?id=524518#c5 should fix this
Carlos Garcia Campos
Comment 2 2014-10-08 08:22:57 PDT
(In reply to comment #1) > Patch attached to: > https://bugs.gentoo.org/show_bug.cgi?id=524518#c5 > > should fix this Could that patch be attached here as well?
Pacho Ramos
Comment 3 2014-10-08 13:46:19 PDT
Created attachment 239492 [details] patch Sure
Pacho Ramos
Comment 4 2014-10-08 13:47:20 PDT
Created attachment 239493 [details] patch (Credits for Michael Weber)
Carlos Garcia Campos
Comment 5 2014-10-22 02:39:20 PDT
Comment on attachment 239493 [details] patch Pushed to 2.4 branch, thanks!
Note You need to log in before you can comment on or make changes to this bug.