Bug 121259 - [GTK] Do not enable VIDEO_TRACK if VIDEO is disabled
Summary: [GTK] Do not enable VIDEO_TRACK if VIDEO is disabled
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alberto Garcia
Depends on:
Reported: 2013-09-12 14:28 PDT by Alberto Garcia
Modified: 2013-09-12 15:21 PDT (History)
4 users (show)

See Also:

Patch (2.59 KB, patch)
2013-09-12 14:34 PDT, Alberto Garcia
mrobinson: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-09-12 14:28:35 PDT
This is what we get if we try to compile with --no-video:

  CXX    Source/JavaScriptCore/llint/Programs_LLIntOffsetsExtractor-LLIntOffsetsExtractor.o
In file included from ../../Source/WTF/wtf/Platform.h:650:0,
                 from ../../Source/JavaScriptCore/config.h:30,
                 from ../../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26:
../../Source/WTF/wtf/FeatureDefines.h:874:2: error: #error "ENABLE(VIDEO_TRACK) requires ENABLE(VIDEO)"
Comment 1 Alberto Garcia 2013-09-12 14:34:46 PDT
Created attachment 211476 [details]

Here's the patch. It makes VIDEO_TRACK follow VIDEO.

Of course it's also possible to have a flag to configure them separately. Should we do that instead?
Comment 2 Martin Robinson 2013-09-12 14:53:38 PDT
Comment on attachment 211476 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=211476&action=review

> Tools/ChangeLog:9
> +        Make VIDEO_TRACK configurable because it needs to be disabled if
> +        VIDEO is also disabled.

Not sure I understand the change, since you say "because it needs to be disabled if VIDEO is also disabled," but it was always disabled before. What you are doing here is enabling VIDEO_TRACK for release builds if video is enabled. Perhaps you're really after some interaction with build-webkit?
Comment 3 Martin Robinson 2013-09-12 15:01:52 PDT
Comment on attachment 211476 [details]

Apologies for how confusing the interaction of build-webkit and configure is, but the features defined in SetupWebKitFeatures.m4 describe the setup for release builds. We do not want to enable video track yet for release builds, so this patch isn't really correct. Furthermore, WebKitFeatureOverrides.txt should override any value you use here, I'm not sure it works.
Comment 4 Alberto Garcia 2013-09-12 15:21:31 PDT
You're right, running build-webkit with --no-video-track is enough, for some reason I thought it was not working.

Sorry for the noise!