RESOLVED FIXED 134801
[GTK] Enable VIDEO_TRACK by default 
https://bugs.webkit.org/show_bug.cgi?id=134801
Summary [GTK] Enable VIDEO_TRACK by default
Carlos Garcia Campos
Reported 2014-07-10 09:02:08 PDT
I'm getting several build failures with this combination that is the default one in GTK+ production builds
Attachments
Patch (1.15 KB, patch)
2014-07-11 04:18 PDT, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2014-07-10 10:05:58 PDT
This can't happen anymore. New JS controls need VIDEO_TRACK. So either we resurrect them or require VIDEO_TRACK.
Carlos Garcia Campos
Comment 2 2014-07-10 10:16:55 PDT
(In reply to comment #1) > This can't happen anymore. New JS controls need VIDEO_TRACK. So either we resurrect them or require VIDEO_TRACK. We can't build with VIDEO_TRACK disabled anymore, we should just remove the option and enabled it unconditionally when video is enabled.
Xabier Rodríguez Calvar
Comment 3 2014-07-10 12:04:03 PDT
(In reply to comment #2) > We can't build with VIDEO_TRACK disabled anymore, we should just remove the option and enabled it unconditionally when video is enabled. Agree.
Xabier Rodríguez Calvar
Comment 4 2014-07-11 02:04:33 PDT
Btw, we could remove MediaControlsGtk.h from the repo, which I forgot at bug 131300.
Carlos Garcia Campos
Comment 5 2014-07-11 04:18:09 PDT
Created attachment 234757 [details] Patch
Carlos Garcia Campos
Comment 6 2014-07-11 05:13:13 PDT
Committed r170997: <http://trac.webkit.org/changeset/170997>
Note You need to log in before you can comment on or make changes to this bug.