Bug 134801 - [GTK] Enable VIDEO_TRACK by default
Summary: [GTK] Enable VIDEO_TRACK by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-07-10 09:02 PDT by Carlos Garcia Campos
Modified: 2014-07-11 05:13 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.15 KB, patch)
2014-07-11 04:18 PDT, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-07-10 09:02:08 PDT 
I'm getting several build failures with this combination that is the default one in GTK+ production builds
Comment 1 Xabier Rodríguez Calvar 2014-07-10 10:05:58 PDT 
This can't happen anymore. New JS controls need VIDEO_TRACK. So either we resurrect them or require VIDEO_TRACK.
Comment 2 Carlos Garcia Campos 2014-07-10 10:16:55 PDT 
(In reply to comment #1)
> This can't happen anymore. New JS controls need VIDEO_TRACK. So either we resurrect them or require VIDEO_TRACK.

We can't build with VIDEO_TRACK disabled anymore, we should just remove the option and enabled it unconditionally when video is enabled.
Comment 3 Xabier Rodríguez Calvar 2014-07-10 12:04:03 PDT 
(In reply to comment #2)
> We can't build with VIDEO_TRACK disabled anymore, we should just remove the option and enabled it unconditionally when video is enabled.

Agree.
Comment 4 Xabier Rodríguez Calvar 2014-07-11 02:04:33 PDT 
Btw, we could remove MediaControlsGtk.h from the repo, which I forgot at bug 131300.
Comment 5 Carlos Garcia Campos 2014-07-11 04:18:09 PDT 
Created attachment 234757 [details]
Patch
Comment 6 Carlos Garcia Campos 2014-07-11 05:13:13 PDT 
Committed r170997: <http://trac.webkit.org/changeset/170997>