Bug 136632 – Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Dominique Leuenberger]

During the inclusion into openSUSE, webkitgtk 2.5.3 has been declined by the legal review due to:

Source / WebInspectorUI / APPLE_IMAGES_LICENSE.rtf

The file states:

"""
\f0\b\fs24 \cf0 Apple Inc.\
Software License Agreement for Web Inspector Images\
Internal Use License Only \'96 No Redistribution Permitted\
\
PLEASE READ THIS SOFTWARE LICENSE AGREEMENT ("LICENSE") CAREFULLY BEFORE USING THE APPLE SOFTWARE INCLUDED IN THIS PACKAGE.  BY USING THIS SOFTWARE, YOU ARE AGREEING TO BE BOUND BY THE TERMS OF THIS LICENSE.  IF YOU DO NOT AGREE TO THE TERMS OF THIS LICENSE, DO NOT USE THIS SOFTWARE.\
\pard\pardeftab720\ri0
"""

This does not sound like a license compatible with the spirit of the rest of webkitgtk, which is licensed under GPL, free to redistribution and modification.

(setting severity 'blocker': this blocks inclusion into openSUSE and thus updating GNOME to 3.14)

[Alberto Garcia]

Thanks for the report.

Can anyone from Apple clarify this?

[Timothy Hatcher]

Correct, the images in Source/WebInspectorUI/UserInterface/Images are covered by this license. If you need to redistribute them, please contact me via email at [e-mail] for details.

[Martin Robinson]

Bumping this to the highest priority. We should fix our tarball ASAP.

[Alberto Garcia]

(In reply to comment #2)
> Correct, the images in Source/WebInspectorUI/UserInterface/Images
> are covered by this license. If you need to redistribute them,
> please contact me via email at [e-mail] for details.

Thanks,

the problem is not that we personally need to redistribute them, but
that license makes them unsuitable for inclusion in the WebKitGTK+
releases.

We need to fix the tarballs and see the implications of this removal.

Adding Emilio to Cc.

[Andres Gomez Garcia]

I will take a look about how to replace the icons ...

[Alberto Garcia]

Created attachment 238245 [details]
Build WebKitGTK+ 2.4.x without the icons

While we are dealing with this, you can remove the affected icons from
the WebKitGTK+ tarball and build it without them.

You can use the attached patch for that (you will also need to run autoreconf).

Of course the inspector is not really usable without the icons, but
everything else should work fine.

[Alberto Garcia]

Created attachment 238246 [details]
Build WebKitGTK+ 2.5.x without the icons

This patch is for the 2.5.x series, which use CMake instead of autotools.

[Michael Catanzaro]

(In reply to comment #6)
> Created an attachment (id=238245) [details]
> While we are dealing with this, you can remove the affected icons from
> the WebKitGTK+ tarball and build it without them.

For Fedora, we're not allowed to use an undistributable tarball at all. We'll have to unpack it, remove the images, apply the patch, and then regenerate the tarball. I know Debian requires this as well. This isn't a huge deal, but if this is going to take some time to resolve, then it'd be very convenient if this could be handled upstream instead.

[Carlos Garcia Campos]

Comment on attachment 238246 [details]
Build WebKitGTK+ 2.5.x without the icons

View in context: https://bugs.webkit.org/attachment.cgi?id=238246&action=review

> Source/WebKit2/PlatformGTK.cmake:-386
> -    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Images/*.png
> -    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Images/*.svg

This is not enough, these files are only to make the dependencies in the build system, but what we pass to generate-inspector-gresource-manifest.py is ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/ that is walked finding files with extensions html, js, css, png or svg. So, we need to remove the png and svg extensions from the list of valid extensions in generate-inspector-gresource-manifest.py.

[Alberto Garcia]

(In reply to comment #8)
> For Fedora, we're not allowed to use an undistributable tarball at
> all. We'll have to unpack it, remove the images, apply the patch,
> and then regenerate the tarball. I know Debian requires this as
> well. This isn't a huge deal, but if this is going to take some time
> to resolve, then it'd be very convenient if this could be handled
> upstream instead.

I know, we're dealing with this and will try to release a new tarball
with a new set of images ASAP.

[Carlos Garcia Campos]

(In reply to comment #9)
> (From update of attachment 238246 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238246&action=review
> 
> > Source/WebKit2/PlatformGTK.cmake:-386
> > -    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Images/*.png
> > -    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Images/*.svg
> 
> This is not enough, these files are only to make the dependencies in the build system, but what we pass to generate-inspector-gresource-manifest.py is ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/ that is walked finding files with extensions html, js, css, png or svg. So, we need to remove the png and svg extensions from the list of valid extensions in generate-inspector-gresource-manifest.py.

The patch in bug #136943 will make this patch work, and will allow us to ignore the apple icons once we have ours.

[Carlos Garcia Campos]

Created attachment 238365 [details]
Patch

This patch adds free replacements for some of the inspector icons, using the GNOME project as a base and adapted by Andrés for the inspector. It also includes the changes in the makefile and scripts to use the new icons, so that once we have more we only need to upload them.

[Carlos Garcia Campos]

I don't know what it didn't apply, could it be that the EWS were not up to date?

[Carlos Garcia Campos]

Created attachment 238366 [details]
Patch

Ok, I submitted the wrong patch, sorry :-P

[Carlos Garcia Campos]

Created attachment 238371 [details]
Updated patch

Forgot to update also the manifest so that the tarball only includes the free icons

[Gustavo Noronha (kov)]

Comment on attachment 238371 [details]
Updated patch

LGTM

[Michael Catanzaro]

Does the tarball still contain the file APPLE_IMAGES_LICENSE.rtf?

[Carlos Garcia Campos]

Committed r173753: <http://trac.webkit.org/changeset/173753>

[Carlos Garcia Campos]

(In reply to comment #17)
> Does the tarball still contain the file APPLE_IMAGES_LICENSE.rtf?

Good point, I added a rule to the manifest to exclude it as well.

[Alberto Garcia]

Okay, WebKitGTK+ 2.4.6 and 2.6.0 contain a new set of free icons, so we have to tell distributors to upgrade or to replace the icons in the packages they're shipping. I'll write a summary of the situation.

[Alberto Garcia]

Ok, I wrote the summary, thanks everyone for their help!

https://lists.webkit.org/pipermail/webkit-gtk/2014-October/002093.html