The file Source/WebInspectorImages/APPLE_IMAGES_LICENSE.rtf begins with the following text: """ Apple Inc. Software License Agreement for Web Inspector Images Internal Use License Only – No Redistribution Permitted PLEASE READ THIS SOFTWARE LICENSE AGREEMENT ("LICENSE") CAREFULLY BEFORE USING THE APPLE SOFTWARE INCLUDED IN THIS PACKAGE. BY USING THIS SOFTWARE, YOU ARE AGREEING TO BE BOUND BY THE TERMS OF THIS LICENSE. IF YOU DO NOT AGREE TO THE TERMS OF THIS LICENSE, DO NOT USE THIS SOFTWARE. """ Clearly this is not acceptable content for the WebKit open source project. It serves no purpose in OpenSource except as a trap to other WebKit ports (see bug #136632, bug #166459) and downstream projects, as it is not usable except by Apple. It should move to Apple's internal repositories until such time that Apple decides to relicense the images under an acceptable content license, e.g. one of the licenses listed at [1]. In the meantime, the GTK port's CC-BY-SA inspector images should be used on all ports. Note that there are fewer GTK images than Apple images. The following Apple icons have no GTK replacement: ActiveCallFrame.svg, AnimationPlayStatePaused.svg, AnimationPlayStateRunning.svg, CallTrees.svg, Camera.svg, ClippingCSSLarge.png, ClippingCSSLarge@2x.png, ClippingGenericLarge.png, ClippingGenericLarge@2x.png, ClippingJSLarge.png, ClippingJSLarge@2x.png, Compare.svg,DocumentCSSLarge.png, DocumentCSSLarge@2x.png, DocumentFontLarge.png, DocumentFontLarge@2x.png, DocumentGenericLarge.png, DocumentGenericLarge@2x.png, DocumentImageLarge.png, DocumentImageLarge@2x.png, DocumentJSLarge.png, DocumentJSLarge@2x.png, DocumentMarkupLarge.png, DocumentMarkupLarge@2x.png, Events.svg, HeapAllocationsInstrument.svg, HeapSnapshot.svg, HeapSnapshotDiff.svg, HeapSnapshotInstances.svg, HeapSnapshotSelected.svg, HeapSnapshotSummary.svg, LayoutInstrument.svg, ListStylePositionInside.svg, ListStylePositionOutside.svg, MemoryInsurment.svg, NetworkInstrument.svg, RenderingFramesInstrument.svg, ScriptsInstrument.svg, Search.svg, Stopwatch.svg, TimelineRecordGarbageCollection.svg, WorkerScript.png, WorkerScript@2x.png, WorkerScriptLarge.png, WorkerScriptLarge@2x.png Note that the GTK images really only exist due to this legal issue. If the Apple images were appropriately-licensed, we could get rid of ours. Although it might seem nice to have images that fit better into GTK, it's not really, because the entire web inspector UI is clearly designed to look like an Apple product, not a GTK+ application. [1] https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing
Oops, forgot the patch. :P
Created attachment 297711 [details] Patch
We are re-investigating what we are able to do w.r.t. licensing. In the meantime, I am not opposed to this in principle, but we are unable to make necessary changes internally until folks are back from holiday break. So please defer this patch until we find a way to make this work without breaking the Mac build.
<rdar://problem/29800966>
(In reply to comment #3) > We are re-investigating what we are able to do w.r.t. licensing. Great, thanks! > In the meantime, I am not opposed to this in principle, but we are unable to > make necessary changes internally until folks are back from holiday break. > So please defer this patch until we find a way to make this work without > breaking the Mac build. Yeah, definitely not planning to land this during the holidays. But I figured having a patch would help... expedite a resolution to this issue. ;) I don't think it breaks the Mac build, though; EWS is clearly green. You will just have a few missing images, the same ones we're missing currently.
Hey Brian et. al., I think we should proceed with an updated version of this patch until such time that you're able to resolve the licensing issues. These files don't belong in OpenSource.
Created attachment 326930 [details] [PATCH] Proposed Fix We've gotten the approval we need within Apple to remove the restrictive license on Web Inspector images.
Comment on attachment 326930 [details] [PATCH] Proposed Fix r=me
Awesome!
Thanks a bunch! And thanks also to Fujii, for helping us keep up with new GTK images recently. Fujii, any objections to removing the GTK inspector images now that we can use Apple's? Seems like it's probably best to unify on one set of images now that we're able to do so?
Comment on attachment 326930 [details] [PATCH] Proposed Fix Clearing flags on attachment: 326930 Committed r224861: <https://trac.webkit.org/changeset/224861>
All reviewed patches have been landed. Closing bug.
Wow, Amazing! I have no objection to remove GTK's images.
Awesome! Thanks to all the people involved and specially to the people at Apple who have pushed and succeeded on getting the approval for relicensing this :) Thanks a lot!
Yeeeeeees! Thank you guys.