We build a list of inspector files in the makefile, but then the script receives the base dirs that are scanned again.
Created attachment 238359 [details] Patch
Attachment 238359 [details] did not pass style-queue: ERROR: Tools/gtk/generate-inspector-gresource-manifest.py:25: expected 2 blank lines, found 1 [pep8/E302] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 238361 [details] Try to make style checker happy
Comment on attachment 238361 [details] Try to make style checker happy View in context: https://bugs.webkit.org/attachment.cgi?id=238361&action=review > Source/WebKit2/PlatformGTK.cmake:500 > + COMMAND ${TOOLS_DIR}/gtk/generate-inspector-gresource-manifest.py --output=${DERIVED_SOURCES_WEBKIT2GTK_DIR}/InspectorGResourceBundle.xml ${InspectorFiles} The new risk here is to exceed command line length limits, I suppose it's ok for now though.
(In reply to comment #4) > (From update of attachment 238361 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238361&action=review > > > Source/WebKit2/PlatformGTK.cmake:500 > > + COMMAND ${TOOLS_DIR}/gtk/generate-inspector-gresource-manifest.py --output=${DERIVED_SOURCES_WEBKIT2GTK_DIR}/InspectorGResourceBundle.xml ${InspectorFiles} > > The new risk here is to exceed command line length limits, I suppose it's ok for now though. Yes, a possible solution might be to pass the relative filenames directly to the script, but I have no idea how to do that with cmake.
Committed r173751: <http://trac.webkit.org/changeset/173751>