SSIA
Created attachment 234968 [details] Patch
Comment on attachment 234968 [details] Patch LGTM
Comment on attachment 234968 [details] Patch Clearing flags on attachment: 234968 Committed r171137: <http://trac.webkit.org/changeset/171137>
All reviewed patches have been landed. Closing bug.
This broke 1 webkitpy test $ Tools/Scripts/test-webkitpy Suppressing most webkitpy logging while running unit tests. Skipping tests in the following modules or packages because they are really, really, slow: webkitpy.common.checkout.scm.scm_unittest (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include) Checking imports .../home/clopez/webkit/webkit [831/1424] webkitpy.style.checker_unittest.GlobalVariablesTest.test_path_rules_specifier failed: Traceback (most recent call last): File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/style/checker_unittest.py", line 225, in test_path_rules_specifier "readability/naming") File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/style/checker_unittest.py", line 212, in assertNoCheck self.assertFalse(config.should_check(category, path), message) AssertionError: True is not False : Should not check category "readability/naming" for path "Source/WebKit/efl/ewk/ewk_view.h". Ran 1424 tests in 6.008s FAILED (failures=1, errors=0) http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/7381
(In reply to comment #5) > This broke 1 webkitpy test > > $ Tools/Scripts/test-webkitpy > Suppressing most webkitpy logging while running unit tests. > Skipping tests in the following modules or packages because they are really, really, slow: > webkitpy.common.checkout.scm.scm_unittest > (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include) > > Checking imports .../home/clopez/webkit/webkit > [831/1424] webkitpy.style.checker_unittest.GlobalVariablesTest.test_path_rules_specifier failed: > Traceback (most recent call last): > File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/style/checker_unittest.py", line 225, in test_path_rules_specifier > "readability/naming") > File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/style/checker_unittest.py", line 212, in assertNoCheck > self.assertFalse(config.should_check(category, path), message) > AssertionError: True is not False : Should not check category "readability/naming" for path "Source/WebKit/efl/ewk/ewk_view.h". > > Ran 1424 tests in 6.008s > FAILED (failures=1, errors=0) > > > > http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/7381 I filed a bug for it - https://bugs.webkit.org/show_bug.cgi?id=134967 Could you review it ?
> I filed a bug for it - https://bugs.webkit.org/show_bug.cgi?id=134967 > > Could you review it ? I'm not a reviewer. Maybe asking on the IRC would help. Thanks.