Bug 134967 - Change style check path with EFL WK2's path in checker_unittest.py
Summary: Change style check path with EFL WK2's path in checker_unittest.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-16 02:32 PDT by Gyuyoung Kim
Modified: 2014-07-16 04:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2014-07-16 02:33 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2014-07-16 03:02 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-07-16 02:32:36 PDT
There is a style check failure in webkitpy tests due to the EFL WK1 path.


[859/1424] webkitpy.style.checker_unittest.GlobalVariablesTest.test_path_rules_specifier failed:
  Traceback (most recent call last):
    File "/home/gyuyoung/buildbot/efl-linux-wk2-slave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/style/checker_unittest.py", line 225, in test_path_rules_specifier
      "readability/naming")
    File "/home/gyuyoung/buildbot/efl-linux-wk2-slave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/style/checker_unittest.py", line 212, in assertNoCheck
      self.assertFalse(config.should_check(category, path), message)
  AssertionError: True is not False : Should not check category "readability/naming" for path "Source/WebKit/efl/ewk/ewk_view.h".
Comment 1 Gyuyoung Kim 2014-07-16 02:33:31 PDT
Created attachment 234985 [details]
Patch
Comment 2 Gyuyoung Kim 2014-07-16 03:02:24 PDT
Created attachment 234989 [details]
Patch
Comment 3 Csaba Osztrogonác 2014-07-16 03:45:12 PDT
Comment on attachment 234989 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2014-07-16 04:21:12 PDT
Comment on attachment 234989 [details]
Patch

Clearing flags on attachment: 234989

Committed r171142: <http://trac.webkit.org/changeset/171142>
Comment 5 WebKit Commit Bot 2014-07-16 04:21:17 PDT
All reviewed patches have been landed.  Closing bug.