Bug 31818 - scm_unittest.py is too slow
Summary: scm_unittest.py is too slow
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-23 20:16 PST by Eric Seidel (no email)
Modified: 2009-12-15 00:57 PST (History)
3 users (show)

See Also:

Patch (1.60 KB, patch)
2009-12-15 00:27 PST, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-23 20:16:03 PST
scm_unittest.py is too slow

If you run run-webkit-unittests -v you'll see that we spend basically all of our time running the unit tests running the scm usit tests.  This is because we create a new svn and git repository on every test and that's slow.  We should find a better way to opt-in to creating a new repository so that we can have faster overall testing.
Comment 1 Adam Barth 2009-12-15 00:27:18 PST
Created attachment 44851 [details]
Comment 2 WebKit Review Bot 2009-12-15 00:28:03 PST
style-queue ran check-webkit-style on attachment 44851 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-15 00:31:17 PST
Comment on attachment 44851 [details]

You might consider using .remove() instead.  Also needs a #HACK or #FIXME comment.
Comment 4 Adam Barth 2009-12-15 00:57:53 PST
Committed r52142: <http://trac.webkit.org/changeset/52142>