Bug 134902 - [Feature Queries] Enable Feature Queries on EFL/GTK
Summary: [Feature Queries] Enable Feature Queries on EFL/GTK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on:
Blocks: 134358
  Show dependency tree / graph
 
Reported: 2014-07-14 14:48 PDT by Bear Travis
Modified: 2014-08-01 13:44 PDT (History)
10 users (show)

See Also:

Attachments
Initial Patch (10.21 KB, patch)
2014-07-14 14:55 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Updated Patch (10.23 KB, patch)
2014-07-15 14:58 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Updating to EFL and GTK only (7.10 KB, patch)
2014-07-16 10:24 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Removing some additional defaults (4.56 KB, patch)
2014-07-16 12:24 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Updated Patch (4.51 KB, patch)
2014-07-17 13:24 PDT, Bear Travis 		benjamin: review+
Details | Formatted Diff | Diff
Updated Patch (5.53 KB, patch)
2014-07-31 16:15 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2014-07-14 14:48:42 PDT 
Bug 134404 turned feature queries on by default on Mac. The other platforms should also have the feature enabled by default.
Comment 1 Bear Travis 2014-07-14 14:55:25 PDT 
Created attachment 234880 [details]
Initial Patch
Comment 2 Bear Travis 2014-07-15 14:58:33 PDT 
Created attachment 234956 [details]
Updated Patch
Comment 3 Bear Travis 2014-07-16 10:24:34 PDT 
Created attachment 235006 [details]
Updating to EFL and GTK only

Will enable on Win port separately as there are some build errors that need investigation
Comment 4 Bear Travis 2014-07-16 12:24:58 PDT 
Created attachment 235015 [details]
Removing some additional defaults

Removing the changes that would toggle the build setting on if not present.
Comment 5 Bear Travis 2014-07-17 13:24:12 PDT 
Created attachment 235086 [details]
Updated Patch
Comment 6 Gyuyoung Kim 2014-07-17 22:26:03 PDT 
Comment on attachment 235086 [details]
Updated Patch

LGTM on EFL side.
Comment 7 Bear Travis 2014-07-31 16:15:19 PDT 
Created attachment 235858 [details]
Updated Patch

Needed to add to FeatureList.pm to get this enabled by default on my EFL build.
Comment 8 WebKit Commit Bot 2014-08-01 13:44:13 PDT 
Comment on attachment 235858 [details]
Updated Patch

Clearing flags on attachment: 235858

Committed r171947: <http://trac.webkit.org/changeset/171947>
Comment 9 WebKit Commit Bot 2014-08-01 13:44:18 PDT 
All reviewed patches have been landed.  Closing bug.