Bug 134404 – [Feature Queries] Enable Feature Queries on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Bear Travis]

The Mac platform does not have ENABLE_CSS3_CONDITIONAL_RULES enabled, which turns on support for CSS3 feature queries.
Turning it on will also enable it in the nightlies as an experimental feature.

[Bear Travis]

Created attachment 234004 [details]
Initial Patch

[Build Bot]

Comment on attachment 234004 [details]
Initial Patch

Attachment 234004 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5559618814083072

New failing tests:
css3/supports-dom-api.html

[Build Bot]

Created attachment 234025 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Bear Travis]

Created attachment 234501 [details]
Updated Patch

Add an existence test for CSS.supports. Test runs locally, so debugging this failure may take a little legwork.

[Build Bot]

Comment on attachment 234501 [details]
Updated Patch

Attachment 234501 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5173918268653568

New failing tests:
css3/supports-dom-api.html

[Build Bot]

Created attachment 234512 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 234501 [details]
Updated Patch

Attachment 234501 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6008284116942848

New failing tests:
css3/supports-dom-api.html

[Build Bot]

Created attachment 234520 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 234501 [details]
Updated Patch

Attachment 234501 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5875380648935424

New failing tests:
media/W3C/video/preload/preload_property_exists.html

[Build Bot]

Created attachment 234521 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Darin Adler]

Comment on attachment 234501 [details]
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234501&action=review

Mac regression test is failing.

> LayoutTests/css3/supports-dom-api.html:10
> +    shouldBeDefined('window.CSS.supports');

I don’t understand why "window." is included here. If we were checking "window.CSS" then it would help, but for checking "CSS.supports" adding the "window." prefix doesn’t help.

[Build Bot]

Comment on attachment 234501 [details]
Updated Patch

Attachment 234501 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5822057690431488

New failing tests:
css3/supports-dom-api.html

[Build Bot]

Created attachment 234524 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Bear Travis]

(In reply to comment #11)
> (From update of attachment 234501 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234501&action=review
> 
> Mac regression test is failing.
> 
> > LayoutTests/css3/supports-dom-api.html:10
> > +    shouldBeDefined('window.CSS.supports');
> 
> I don’t understand why "window." is included here. If we were checking "window.CSS" then it would help, but for checking "CSS.supports" adding the "window." prefix doesn’t help.

Ah, yes. The test was meant to ensure that CSS exists on the window object, but it would make more sense to just test window.CSS then. Will fix this up in the next iteration, still working through the test failures.

[Bear Travis]

Created attachment 234603 [details]
Updated Patch

Some of the CSS productions were not properly returning values, which caused the release build to crash in certain cases.

[Build Bot]

Comment on attachment 234603 [details]
Updated Patch

Attachment 234603 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6676936705179648

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 234609 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Bear Travis]

Created attachment 234643 [details]
Updating Patch

[Antti Koivisto]

Comment on attachment 234643 [details]
Updating Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234643&action=review

> Source/WebCore/css/CSSGrammar.y.in:747
> -    | supports_declaration_condition
> -    | '(' error ')'
> +    | supports_declaration_condition { $$ = $1; }
> +    | '(' error ')' { $$ = false; }

Please do any non-build file changes separately.

[Bear Travis]

Created attachment 234775 [details]
Patch sans CSSGrammar changes

Moved the changes to GSSGrammar.y.in to bug 134358.

[WebKit Commit Bot]

Comment on attachment 234775 [details]
Patch sans CSSGrammar changes

Clearing flags on attachment: 234775

Committed r171075: <http://trac.webkit.org/changeset/171075>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Benjamin Poulain]

*** Bug 126636 has been marked as a duplicate of this bug. ***