Bug 132243 – [CSSRegions] Slider displayed wrong in regions

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mihnea Ovidenie]

Created attachment 230281 [details]
Test case

In the attached test case, a absolutely positioned input element of type range, displayed in the second region, does not have its thumb displayed. If you change the test to display the slider in the first region or you change its parent display to block, the slider is correctly displayed.

[Andrei Bucur]

Created attachment 230826 [details]
Patch

[Andrei Bucur]

*** Bug 131032 has been marked as a duplicate of this bug. ***

[Mihnea Ovidenie]

Comment on attachment 230826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230826&action=review

r=me

> Source/WebCore/rendering/RenderFlowThread.cpp:808
> +        // video box becasue it's not a block; they need to be patched separately).

nit: because

[Andrei Bucur]

Created attachment 230828 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 230828 [details]
Patch for landing

Clearing flags on attachment: 230828

Committed r168286: <http://trac.webkit.org/changeset/168286>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

Looks like this patch caused 1.5% to 2% perf. regressions on html5-full-render:
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22mac-mountainlion%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D&days=5

[Andreas Kling]

(In reply to comment #7)
> Looks like this patch caused 1.5% to 2% perf. regressions on html5-full-render:
> https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22mac-mountainlion%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D&days=5

I don't think that test will ever hit this code path in RenderFlowThread.

[Andrei Bucur]

Taking a look now.

[Andrei Bucur]

html5-full-render uses multi-col :). It might have been caused by enabling the new-multicol implementation or by this patch. I'm trying to optimize getRegionRangeForBox.

[Andrei Bucur]

Indeed it seems there's a regression here. I'm looking for a fix.

[Andrei Bucur]

I've filed a new bug for this: https://bugs.webkit.org/show_bug.cgi?id=132672