Bug 132672 - [CSS Regions] 1-2% performance regression in html5-full-render after r168286
Summary: [CSS Regions] 1-2% performance regression in html5-full-render after r168286
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 128243
  Show dependency tree / graph
 
Reported: 2014-05-08 01:13 PDT by Andrei Bucur
Modified: 2014-05-09 09:16 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.54 KB, patch)
2014-05-09 02:00 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch that applies (4.54 KB, patch)
2014-05-09 02:05 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2014-05-08 01:13:18 PDT 
After new-multi was enabled the RenderFlowThread code path started affecting some of the performance tests (some have multi-column elements). Investigate this regression and find a fix for it.
Comment 1 Andrei Bucur 2014-05-08 01:14:02 PDT 
The changeset to blame: http://trac.webkit.org/changeset/168286
Comment 2 Andrei Bucur 2014-05-09 02:00:10 PDT 
Created attachment 231135 [details]
Patch
Comment 3 Andrei Bucur 2014-05-09 02:05:55 PDT 
Created attachment 231136 [details]
Patch that applies
Comment 4 Mihnea Ovidenie 2014-05-09 04:03:08 PDT 
Comment on attachment 231136 [details]
Patch that applies

r=me. Instead of testing the single region case directly, it may be a good idea to have a helper function.
Comment 5 Andrei Bucur 2014-05-09 08:45:14 PDT 
I don't suspect I'll use this condition in more places. I'm kinda skeptical having a function hasOneRegion actually brings value.

If this is an optimization that can be applied in other places as well, I'll create that helper function.
Comment 6 WebKit Commit Bot 2014-05-09 09:16:28 PDT 
Comment on attachment 231136 [details]
Patch that applies

Clearing flags on attachment: 231136

Committed r168534: <http://trac.webkit.org/changeset/168534>
Comment 7 WebKit Commit Bot 2014-05-09 09:16:32 PDT 
All reviewed patches have been landed.  Closing bug.