Bug 131510 – [iOS WebKit2] Implement find-in-page indicator

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

The current implementation is NSWindow based; that won't work.

<rdar://problem/16547777>

[Tim Horton]

Created attachment 229172 [details]
patch

[WebKit Commit Bot]

Attachment 229172 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h:40:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h:41:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h:42:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/ChangeLog:9:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 4 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 229172 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229172&action=review

> Source/WebCore/ChangeLog:3
> +        [iOS WebKit2] Yellow find-in-page indicator

Does it being yellow matter?

> Source/WebCore/ChangeLog:9
> +        No new tests (OOPS!).

OOPS

[Enrica Casucci]

Comment on attachment 229172 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229172&action=review

Looks good to me.

> Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:81
> +{

It would be nice to use Frame& and make Andreas happy :-)

> Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:121
> +{

You should probably add a FIXME to deal with subframes in the future.

> Source/WebKit2/WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h:37
> +    void setFrame(WebCore::Frame* frame) { m_frame = frame; }

Reference?

> Source/WebKit2/WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h:42
> +    virtual void didMoveToWebPage(PageOverlay*, WebPage*) override {}

Style requires a space between {}

[Tim Horton]

http://trac.webkit.org/changeset/167169