Bug 131560 – Support document-relative and custom-frame page overlays

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

Most page overlays are really document overlays.

[Radar WebKit Bug Importer]

<rdar://problem/16595556>

[Tim Horton]

Created attachment 229160 [details]
patch

[Tim Horton]

Created attachment 229161 [details]
patch

[WebKit Commit Bot]

Attachment 229161 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLayerCompositor.h:307:  The parameter name "documentOverlayRootLayer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/PageOverlay.h:95:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 229161 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229161&action=review

> Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp:104
> +    if (overlay->overlayType() == PageOverlay::OverlayType::View) {
> +        if (Page* page = m_webPage->corePage()) {
> +            if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator())
> +                scrollingCoordinator->setForceSynchronousScrollLayerPositionUpdates(true);
> +        }

Why not just call updateForceSynchronousScrollLayerPositionUpdates()?

> Source/WebKit2/WebProcess/WebPage/PageOverlayController.h:38
> +namespace WebCore {
> +class Frame;
> +}

Remove. You just use WebCore::Frame below.

[Tim Horton]

http://trac.webkit.org/changeset/167152