Bug 131560 - Support document-relative and custom-frame page overlays
Summary: Support document-relative and custom-frame page overlays
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks: 131510
  Show dependency tree / graph
 
Reported: 2014-04-11 13:41 PDT by Tim Horton
Modified: 2014-04-11 14:50 PDT (History)
9 users (show)

See Also:

Attachments
patch (32.00 KB, patch)
2014-04-11 14:08 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (32.19 KB, patch)
2014-04-11 14:10 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-04-11 13:41:12 PDT 
Most page overlays are really document overlays.
Comment 1 Radar WebKit Bug Importer 2014-04-11 13:41:35 PDT 
<rdar://problem/16595556>
Comment 2 Tim Horton 2014-04-11 14:08:36 PDT 
Created attachment 229160 [details]
patch
Comment 3 Tim Horton 2014-04-11 14:10:36 PDT 
Created attachment 229161 [details]
patch
Comment 4 WebKit Commit Bot 2014-04-11 14:11:32 PDT 
Attachment 229161 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLayerCompositor.h:307:  The parameter name "documentOverlayRootLayer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/PageOverlay.h:95:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Simon Fraser (smfr) 2014-04-11 14:17:47 PDT 
Comment on attachment 229161 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229161&action=review

> Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp:104
> +    if (overlay->overlayType() == PageOverlay::OverlayType::View) {
> +        if (Page* page = m_webPage->corePage()) {
> +            if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator())
> +                scrollingCoordinator->setForceSynchronousScrollLayerPositionUpdates(true);
> +        }

Why not just call updateForceSynchronousScrollLayerPositionUpdates()?

> Source/WebKit2/WebProcess/WebPage/PageOverlayController.h:38
> +namespace WebCore {
> +class Frame;
> +}

Remove. You just use WebCore::Frame below.
Comment 6 Tim Horton 2014-04-11 14:42:11 PDT 
http://trac.webkit.org/changeset/167152