Bug 131563 - [iOS WebKit2] Expose a simplified zoom-to-rect to the WebProcess
Summary: [iOS WebKit2] Expose a simplified zoom-to-rect to the WebProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks: 131510
  Show dependency treegraph
 
Reported: 2014-04-11 14:51 PDT by Tim Horton
Modified: 2017-03-07 23:34 PST (History)
4 users (show)

See Also:


Attachments
patch (6.56 KB, patch)
2014-04-11 14:53 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-04-11 14:51:35 PDT
Add a simple message that calls WKContentView's zoom-to-rect code given just a rect and min/max scale.
Comment 1 Tim Horton 2014-04-11 14:53:00 PDT
Created attachment 229163 [details]
patch
Comment 2 WebKit Commit Bot 2014-04-11 14:54:51 PDT
Attachment 229163 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:610:  The parameter name "rect" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/PageClient.h:252:  The parameter name "rect" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ios/PageClientImplIOS.h:125:  The parameter name "rect" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-04-11 14:55:53 PDT
http://trac.webkit.org/changeset/167154
Comment 4 Tim Horton 2014-04-11 14:57:31 PDT
And http://trac.webkit.org/changeset/167155 for the stylebot.
Comment 5 Tim Horton 2017-03-07 23:34:28 PST
Why did I do this? Nothing calls it?