WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 131563
[iOS WebKit2] Expose a simplified zoom-to-rect to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=131563
Summary
[iOS WebKit2] Expose a simplified zoom-to-rect to the WebProcess
Tim Horton
Reported
2014-04-11 14:51:35 PDT
Add a simple message that calls WKContentView's zoom-to-rect code given just a rect and min/max scale.
Attachments
patch
(6.56 KB, patch)
2014-04-11 14:53 PDT
,
Tim Horton
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2014-04-11 14:53:00 PDT
Created
attachment 229163
[details]
patch
WebKit Commit Bot
Comment 2
2014-04-11 14:54:51 PDT
Attachment 229163
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:610: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/PageClient.h:252: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/ios/PageClientImplIOS.h:125: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3
2014-04-11 14:55:53 PDT
http://trac.webkit.org/changeset/167154
Tim Horton
Comment 4
2014-04-11 14:57:31 PDT
And
http://trac.webkit.org/changeset/167155
for the stylebot.
Tim Horton
Comment 5
2017-03-07 23:34:28 PST
Why did I do this? Nothing calls it?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug