Move to using std::unique_ptr for opengl, texmap, transforms and efl in WebCore/platform/graphics.
Created attachment 228697 [details] Patch
Created attachment 228699 [details] Patch
Created attachment 228733 [details] Patch
Comment on attachment 228733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228733&action=review > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.h:39 > + static std::unique_ptr<GraphicsContext3DPrivate> create(GraphicsContext3D*, HostWindow*); Not sure we really need this any more. Caller can just use make_unique. > Source/WebCore/platform/graphics/texmap/TextureMapper.h:119 > + static std::unique_ptr<TextureMapper> create(AccelerationMode newMode = SoftwareMode); Argument name “newMode” should be deleted. Also, I don’t think we really need this. Caller can just use make_unique.
Comment on attachment 228733 [details] Patch Clearing flags on attachment: 228733 Committed r166889: <http://trac.webkit.org/changeset/166889>
All reviewed patches have been landed. Closing bug.
(In reply to comment #5) > (From update of attachment 228733 [details]) > Clearing flags on attachment: 228733 > > Committed r166889: <http://trac.webkit.org/changeset/166889> It broke the WinCairo build - http://build.webkit.org/builders/WinCairo%20Release/builds/38167/steps/compile-webkit/logs/stdio
It also broke video rendering in WebKitGTK https://bugs.webkit.org/show_bug.cgi?id=131488
Comment on attachment 228733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228733&action=review > Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:-52 > - Why are you removing this?
This patch sent us comically down the software path unconditionally, because it deleted the TextureMapperGL::create(...) static method, but didn't change the callsite. We've fixed it in https://bugs.webkit.org/show_bug.cgi?id=131471.
I'm sorry about the breakage on WinCairo and GTK. And thanks for fixing it.
(In reply to comment #11) > I'm sorry about the breakage on WinCairo and GTK. > And thanks for fixing it. No problem. The code is cleaner with your changes.