Bug 131360 - [WinCairo] Compile error in TextureMapper.h
Summary: [WinCairo] Compile error in TextureMapper.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 131276
  Show dependency tree / graph
 
Reported: 2014-04-08 08:26 PDT by peavo
Modified: 2014-04-08 09:40 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2014-04-08 08:32 PDT, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2014-04-08 08:26:52 PDT 
I'm getting this compile error, when compiling WinCairo:

"error C2259: 'WebCore::TextureMapper' : cannot instantiate abstract class"

The TextureMapper class has pure virtual methods, and cannot be instantiated.
Comment 1 peavo 2014-04-08 08:32:33 PDT 
Created attachment 228839 [details]
Patch
Comment 2 Brent Fulgham 2014-04-08 08:59:15 PDT 
This looks fine, but I'll wait for the EFL EWS bot to run before approving.
Comment 3 Brent Fulgham 2014-04-08 09:08:45 PDT 
Caused by Bug 131276.
Comment 4 Brent Fulgham 2014-04-08 09:10:40 PDT 
Comment on attachment 228839 [details]
Patch

r=me. Let's keep an eye on EFL to make sure nothing breaks there. GTK already looks good.
Comment 5 peavo 2014-04-08 09:16:46 PDT 
(In reply to comment #4)
> (From update of attachment 228839 [details])
> r=me. Let's keep an eye on EFL to make sure nothing breaks there. GTK already looks good.

Thanks :)
Comment 6 WebKit Commit Bot 2014-04-08 09:40:30 PDT 
Comment on attachment 228839 [details]
Patch

Clearing flags on attachment: 228839

Committed r166931: <http://trac.webkit.org/changeset/166931>
Comment 7 WebKit Commit Bot 2014-04-08 09:40:34 PDT 
All reviewed patches have been landed.  Closing bug.