Bug 130975 – [CSS Shapes] Simplify Polygon implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Hans Muller]

This change is similar to https://bugs.webkit.org/show_bug.cgi?id=130916

The final CSS Shapes level 1 spec (http://dev.w3.org/csswg/css-shapes-1/) does not include shape-inside only allows shape-outside to be specified on floats.  In light of this, the PolygonShape class can be substantially simplified.

The support for shape-inside has already been removed, see https://bugs.webkit.org/show_bug.cgi?id=130740

A detailed look at the PolygonShape simplification can be found here: http://hansmuller-webkit.blogspot.com/2014/03/a-simpler-algorithm-for-css-shapes.html

[Hans Muller]

Created attachment 228447 [details]
Patch

Only floats can specify shape-outside. For polygon shape values, the problem of finding the left and right exclusion edges reduces to finding the X axis limits of the polygon edges that overlap a particular line. This is a much simpler version of the problem that PolygonShape was designed for, and so the implementation can also be simplified. There's more about the new algorithm in http://hansmuller-webkit.blogspot.com/2014/03/a-simpler-algorithm-for-css-shapes.html.

[Andreas Kling]

Comment on attachment 228447 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 228447 [details]
Patch

Clearing flags on attachment: 228447

Committed r166790: <http://trac.webkit.org/changeset/166790>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.