Bug 130916 - [CSS Shapes] Simplify RasterShape implementation
Summary: [CSS Shapes] Simplify RasterShape implementation
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
Depends on: 130740
  Show dependency treegraph
Reported: 2014-03-28 16:28 PDT by Hans Muller
Modified: 2014-03-31 13:55 PDT (History)
6 users (show)

See Also:

Patch (14.18 KB, patch)
2014-03-28 16:46 PDT, Hans Muller
no flags Details | Formatted Diff | Diff
Patch (14.17 KB, patch)
2014-03-28 16:52 PDT, Hans Muller
dino: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (14.07 KB, patch)
2014-03-31 12:59 PDT, Hans Muller
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (14.07 KB, patch)
2014-03-31 13:18 PDT, Hans Muller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2014-03-28 16:28:41 PDT
The final CSS Shapes level 1 spec (http://dev.w3.org/csswg/css-shapes-1/) does not include shape-inside only allows shape-outside to be specified on floats.  In light of this, the RasterShape class can be substantially simplified.

The support for shape-inside has already been removed, see https://bugs.webkit.org/show_bug.cgi?id=130740

Since only floats can specify shape-outside, the RasterShapeIntervals class need only track the first and last above threshold pixel column (x1 and x2 in the implementation) for each row.
Comment 1 Hans Muller 2014-03-28 16:46:05 PDT
Created attachment 228090 [details]
Comment 2 WebKit Commit Bot 2014-03-28 16:47:09 PDT
Attachment 228090 [details] did not pass style-queue:

ERROR: Source/WebCore/rendering/shapes/Shape.cpp:200:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/rendering/shapes/Shape.cpp:200:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Hans Muller 2014-03-28 16:52:58 PDT
Created attachment 228092 [details]

Removed a comment that offended the style checker.
Comment 4 WebKit Commit Bot 2014-03-31 11:31:39 PDT
Comment on attachment 228092 [details]

Rejecting attachment 228092 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 228092, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:

Hunk #2 succeeded at 83 with fuzz 1.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/shapes/RasterShape.h.rej
patching file Source/WebCore/rendering/shapes/Shape.cpp
Hunk #1 succeeded at 195 (offset -2 lines).
Hunk #2 succeeded at 204 (offset -2 lines).
patching file Source/WebCore/rendering/shapes/ShapeInterval.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5748843891130368
Comment 5 Hans Muller 2014-03-31 12:59:15 PDT
Created attachment 228192 [details]

Comment 6 WebKit Commit Bot 2014-03-31 13:15:01 PDT
Comment on attachment 228192 [details]

Rejecting attachment 228192 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 228192, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/4773537348845568
Comment 7 Hans Muller 2014-03-31 13:18:34 PDT
Created attachment 228197 [details]

Fixed ChangeLog "reviewed by" entry.
Comment 8 WebKit Commit Bot 2014-03-31 13:55:38 PDT
Comment on attachment 228197 [details]

Clearing flags on attachment: 228197

Committed r166522: <http://trac.webkit.org/changeset/166522>
Comment 9 WebKit Commit Bot 2014-03-31 13:55:42 PDT
All reviewed patches have been landed.  Closing bug.