Bug 130300 - Add CompareStrictEq(StringIdent:, NotStringVar:) and CompareStrictEq(String:, Untyped:)
Summary: Add CompareStrictEq(StringIdent:, NotStringVar:) and CompareStrictEq(String:,...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 130449
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2014-03-15 23:14 PDT by Filip Pizlo
Modified: 2014-03-19 04:14 PDT (History)
11 users (show)

See Also:

Attachments
work in progress (12.71 KB, patch)
2014-03-16 17:57 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
moar! (32.42 KB, patch)
2014-03-16 18:24 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
getting there (55.12 KB, patch)
2014-03-16 21:28 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
basically done (72.28 KB, patch)
2014-03-17 21:53 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (72.35 KB, patch)
2014-03-18 12:35 PDT, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-03-15 23:14:07 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-03-16 17:57:30 PDT 
Created attachment 226867 [details]
work in progress
Comment 2 Filip Pizlo 2014-03-16 18:24:55 PDT 
Created attachment 226868 [details]
moar!
Comment 3 Filip Pizlo 2014-03-16 18:27:08 PDT 
I'm using this as an opportunity to add is-cell/is-not-cell/is-other/is-not-other branch abstractions to deduplicate more 64-bit/32-bit code.
Comment 4 Filip Pizlo 2014-03-16 21:28:47 PDT 
Created attachment 226876 [details]
getting there

I wrote all of the DFG code, but there is still some FTL code to write.
Comment 5 Filip Pizlo 2014-03-17 21:53:55 PDT 
Created attachment 227011 [details]
basically done
Comment 6 Filip Pizlo 2014-03-18 12:35:14 PDT 
Created attachment 227089 [details]
the patch
Comment 7 Mark Hahnenberg 2014-03-18 13:37:35 PDT 
Comment on attachment 227089 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227089&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3859
> +    JITCompiler::JumpList fastSlow;

fastFalse
Comment 8 Filip Pizlo 2014-03-18 13:54:17 PDT 
Landed in http://trac.webkit.org/changeset/165842
Comment 9 Csaba Osztrogonác 2014-03-19 04:14:03 PDT 
(In reply to comment #8)
> Landed in http://trac.webkit.org/changeset/165842

It caused regression on 32 bit x86 - https://bugs.webkit.org/show_bug.cgi?id=130449