Bug 129129 - DFG should do its own static estimates of execution frequency before it starts creating OSR entrypoints
Summary: DFG should do its own static estimates of execution frequency before it start...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
: 129055 (view as bug list)
Depends on:
Blocks: 112840
  Show dependency treegraph
Reported: 2014-02-20 16:46 PST by Filip Pizlo
Modified: 2014-02-23 19:54 PST (History)
15 users (show)

See Also:

the patch (26.55 KB, patch)
2014-02-20 17:00 PST, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-20 16:46:08 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2014-02-20 17:00:31 PST
Created attachment 224809 [details]
the patch
Comment 2 WebKit Commit Bot 2014-02-20 17:01:55 PST
Attachment 224809 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/dfg/DFGBasicBlock.cpp:53:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 17 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2014-02-20 17:10:54 PST
Comment on attachment 224809 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224809&action=review


> Source/JavaScriptCore/ChangeLog:15
> +        This is better than letting LLVM do its own static estimates, since by the time we
> +        generate LLVM IR, we may have messed up the CFG due to OSR entrypoint creation. Of
> +        course, it would be even better if we just slurped in some kind of execution counts
> +        from profiling, but we don't do that, yet.

Do want.
Comment 4 Filip Pizlo 2014-02-20 17:15:47 PST
Landed in http://trac.webkit.org/changeset/164459
Comment 5 Filip Pizlo 2014-02-23 19:54:45 PST
*** Bug 129055 has been marked as a duplicate of this bug. ***