AX: shadow DOM video controls only has partial FKA support (need arrow keys handled on menu and focus styles tweaked) 
https://bugs.webkit.org/show_bug.cgi?id=127260
Summary AX: shadow DOM video controls only has partial FKA support (need arrow keys h...
James Craig
Reported 2014-01-19 21:03:01 PST
AX: video controls popup menu arrow key handling only partially handled (page still scrolls sometimes) My assumption is that this is because the menu change is triggered via keyup (which is being canceled) but the scroll event is triggered via keypress (probably need to cancel this event, too.) Source/WebCore/Modules/mediacontrols/mediaControlsApple.js
Attachments
js patch (1.74 KB, patch)
2014-01-20 01:48 PST, James Craig 		no flags
DetailsFormatted DiffDiff
js patch with partial layout test (2.90 KB, patch)
2014-01-20 10:20 PST, James Craig 		no flags
DetailsFormatted DiffDiff
js patch with partial layout test (attachment includes layout test this time) (9.71 KB, patch)
2014-01-20 11:26 PST, James Craig 		no flags
DetailsFormatted DiffDiff
temp patch with non-working layout test (12.93 KB, patch)
2014-02-19 01:12 PST, James Craig 		no flags
DetailsFormatted DiffDiff
Patch (13.08 KB, patch)
2016-11-10 17:14 PST, Aaron Chu 		cfleizach: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (8.96 MB, application/zip)
2016-11-10 18:10 PST, Build Bot 		no flags
Details
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-19 21:03:35 PST
<rdar://problem/15856121>
James Craig
Comment 2 2014-01-19 21:55:21 PST
spacebar too, when the menuitem is selected.
James Craig
Comment 3 2014-01-20 01:48:07 PST
Created attachment 221635 [details] js patch
James Craig
Comment 4 2014-01-20 10:20:24 PST
Created attachment 221671 [details] js patch with partial layout test
James Craig
Comment 5 2014-01-20 11:26:28 PST
Created attachment 221676 [details] js patch with partial layout test (attachment includes layout test this time) Getting some strange runtime errors in the test that seem to be unrelated to my patch. Clearly need to resolve that before review.
James Craig
Comment 6 2014-02-19 01:12:01 PST
Created attachment 224605 [details] temp patch with non-working layout test Going to put this one aside for now since the Shadow DOM work has been pulled out of TOT. I'll pick this back up if/when the Shadow DOM versions are being used again.
James Craig
Comment 7 2014-02-19 01:16:31 PST
*** Bug 127267 has been marked as a duplicate of this bug. ***
James Craig
Comment 8 2014-04-15 17:22:03 PDT
Looks like this might be unblocked again. There is some activity on bug 120956 indicating the JS controls are back.
James Craig
Comment 9 2016-07-20 13:18:58 PDT
Unblocked by bug 117857. Reassigning to Aaron to resolve the visible keyboard focus bugs.
Aaron Chu
Comment 10 2016-11-10 17:14:11 PST
Created attachment 294445 [details] Patch
Ryosuke Niwa
Comment 11 2016-11-10 17:18:12 PST
The last I checked, this was somehow intentional and changing this would require some sort of a HI review.
Build Bot
Comment 12 2016-11-10 18:10:26 PST
Comment on attachment 294445 [details] Patch Attachment 294445 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2494212 New failing tests: media/ensure-media-controls-have-focus-rings.html
Build Bot
Comment 13 2016-11-10 18:10:30 PST
Created attachment 294453 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
chris fleizach
Comment 14 2017-11-17 16:21:43 PST
Comment on attachment 294445 [details] Patch r- until HI approves
Note You need to log in before you can comment on or make changes to this bug.