RESOLVED FIXED 127076
check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp 
https://bugs.webkit.org/show_bug.cgi?id=127076
Summary check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
Blaze Burg
Reported 2014-01-15 16:57:01 PST
Found in patch here: https://bugs.webkit.org/show_bug.cgi?id=127068
Attachments
Patch (2.34 KB, patch)
2014-02-17 10:29 PST, Laszlo Vidacs 		no flags
DetailsFormatted DiffDiff
Patch (2.55 KB, patch)
2014-02-26 16:06 PST, Laszlo Vidacs 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-02-14 07:32:39 PST
The problem is that style-checker thinks if it is a part of a member initialization. similar problem occured in https://bugs.webkit.org/show_bug.cgi?id=128579 Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:239 ... ::glResolveMultisampleFramebufferAPPLE(); ... https://bugs.webkit.org/show_bug.cgi?id=127068 Source/WebKit/win/WebNodeHighlight.cpp:168: ... ::SelectObject(hdc.get(), hbmp.get()); ...
Laszlo Vidacs
Comment 2 2014-02-17 10:29:13 PST
Created attachment 224394 [details] Patch
Ryosuke Niwa
Comment 3 2014-02-26 15:51:23 PST
Comment on attachment 224394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224394&action=review > Tools/ChangeLog:8 > + Avoid match for :: Could you describe what the false positive was and what you're changing? This is too terse of a description.
Laszlo Vidacs
Comment 4 2014-02-26 16:06:44 PST
Created attachment 225315 [details] Patch
WebKit Commit Bot
Comment 5 2014-02-27 08:56:43 PST
Comment on attachment 225315 [details] Patch Clearing flags on attachment: 225315 Committed r164806: <http://trac.webkit.org/changeset/164806>
WebKit Commit Bot
Comment 6 2014-02-27 08:56:46 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2014-03-03 05:27:46 PST
*** Bug 126554 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.