Bug 127068 – Web Inspector: Page should use std::unique_ptr for InspectorController

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

I think i'll split this task from https://bugs.webkit.org/show_bug.cgi?id=126771 since this refactoring step mostly deals with call sites non-inspector code.

[Blaze Burg]

Created attachment 221317 [details]
v1

[WebKit Commit Bot]

Attachment 221317 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMWindowBase.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageDebuggable.cpp', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.h', u'Source/WebCore/workers/WorkerMessagingProxy.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp', u'Source/WebKit/gtk/webkit/webkitwebinspector.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/WebInspector.mm', u'Source/WebKit/mac/WebInspector/WebNodeHighlighter.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp', u'Source/WebKit/win/WebInspector.cpp', u'Source/WebKit/win/WebNodeHighlight.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit/win/WebNodeHighlight.cpp:168:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebKit/win/WebNodeHighlight.cpp:168:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Radar WebKit Bug Importer]

<rdar://problem/15830904>

[Radar WebKit Bug Importer]

<rdar://problem/15830903>

[Blaze Burg]

Filed check-webkit-style bug: https://bugs.webkit.org/show_bug.cgi?id=127076

[EFL EWS Bot]

Comment on attachment 221317 [details]
v1

Attachment 221317 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5536423700594688

[kov's GTK+ EWS bot]

Comment on attachment 221317 [details]
v1

Attachment 221317 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/5462541673168896

[Sam Weinig]

Comment on attachment 221317 [details]
v1

r=me in principle.  But you should fix the builds.

[Joseph Pecoraro]

View in context: https://bugs.webkit.org/attachment.cgi?id=221317&action=review

> Source/WebCore/inspector/InspectorController.h:80
> +    explicit InspectorController(Page&, InspectorClient*);

The explicit keyword is only needed on constructors with a single parameter, to prevent implicit conversions. It is not needed here (and on plenty of other cases in this patch).

> Source/WebCore/inspector/WorkerInspectorController.cpp:137
> +    m_frontendChannel.reset();

I think we prefer "= nullptr" instead of reset. I certainly have with Inspector unique_ptrs. Am I out of date on that?

[Blaze Burg]

Created attachment 221384 [details]
v2

[WebKit Commit Bot]

Attachment 221384 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMWindowBase.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageDebuggable.cpp', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.h', u'Source/WebCore/workers/WorkerMessagingProxy.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp', u'Source/WebKit/gtk/webkit/webkitwebinspector.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/WebInspector.mm', u'Source/WebKit/mac/WebInspector/WebNodeHighlighter.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp', u'Source/WebKit/win/WebInspector.cpp', u'Source/WebKit/win/WebNodeHighlight.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit/win/WebNodeHighlight.cpp:168:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebKit/win/WebNodeHighlight.cpp:168:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 221384 [details]
v2

Attachment 221384 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5411048974712832

[Blaze Burg]

Created attachment 221420 [details]
v3

[WebKit Commit Bot]

Attachment 221420 [details] did not pass style-queue:


ERROR: Source/WebKit/win/WebNodeHighlight.cpp:168:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebKit/win/WebNodeHighlight.cpp:168:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 221420 [details]
v3

Attachment 221420 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5504649196994560

[Blaze Burg]

I think I've addressed all of the build failures, but EWS is uncooperative at this time.

[Joseph Pecoraro]

Comment on attachment 221420 [details]
v3

rs=me

I suggest when you land this that you watch the bots just in case.

[Blaze Burg]

Committed r162264: <http://trac.webkit.org/changeset/162264>