RESOLVED FIXED 126771
Web Inspector: use c++11 features in web-only agents 
https://bugs.webkit.org/show_bug.cgi?id=126771
Summary Web Inspector: use c++11 features in web-only agents
Blaze Burg
Reported 2014-01-10 12:18:05 PST
This has been annoying me. :)
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-10 12:22:42 PST
<rdar://problem/15794772>
Timothy Hatcher
Comment 2 2014-01-10 12:30:07 PST
Joe fixed InspectorAgent in bug 126763 when he moved it to JSC. No need to do that one, you will just conflict.
Blaze Burg
Comment 3 2014-01-10 13:15:10 PST
Joe is handling this when moving stuff around to JSC.
Joseph Pecoraro
Comment 4 2014-01-10 13:17:42 PST
Yes, as I've been moving code down into JSC I've been making it sparkle. So nullptr, unique_ptr, some references, better whitespace, etc. There is plenty of code that code be updated in WebCore though. InstrumentingAgents, any WebCore agent (so not Runtime/Debugger). I'll happily review a patch making these changes.
Joseph Pecoraro
Comment 5 2014-01-10 13:18:28 PST
Another big one that is annoying me: OVERRIDE, FINAL
Joseph Pecoraro
Comment 6 2014-01-10 14:20:07 PST
Another big one that is annoying me: ASCIILiteral
Joseph Pecoraro
Comment 7 2014-01-17 17:14:25 PST
With Anders help I was about to get clang-modernize working. With that we can automate adding "override" where it is needed and using "nullptr". It makes a bunch of changes: Transform: AddOverride - Accepted: 1488 Transform: UseNullptr - Accepted: 267 Though I should first let Brian's more involved Reference change land first.
Joseph Pecoraro
Comment 8 2014-01-20 13:30:59 PST
Fixed nullptr and override with: <https://webkit.org/b/127206> Modernize WebCore/inspector with override <https://webkit.org/b/127303> Modernize WebCore/inspector with nullptr
Joseph Pecoraro
Comment 9 2014-08-01 14:19:38 PDT
Pretty sure this is fixed, right? nullptr, override, final, lots of unique_ptr. We can file new bugs about other things (ASCIILiteral, References).
Note You need to log in before you can comment on or make changes to this bug.